Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 851027 - net-libs/webkit-gtk needs broader BDEPEND on gdbus-codegen
Summary: net-libs/webkit-gtk needs broader BDEPEND on gdbus-codegen
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-10 13:31 UTC by Daniel M. Weeks
Modified: 2022-06-14 17:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel M. Weeks 2022-06-10 13:31:23 UTC
Below with USE=X egl introspection jpeg2k jumbo-build seccomp

Without gdbus-codegen installed the build fails:

FAILED: WebCore/DerivedSources/AccessibilityAtspiInterfaces.h WebCore/DerivedSources/AccessibilityAtspiInterfaces.c /tmp/portage/net-libs/webkit-gtk-2.36.1/work/webkit-gtk-2.36.1_build/WebCore/DerivedSources/AccessibilityAtspiInterfaces.h /tmp/portage/net-libs/webkit-gtk-2.36.1/work/webkit-gtk-2.36.1_build/WebCore/DerivedSources/AccessibilityAtspiInterfaces.c

/bin/sh: line 1: gdbus-codegen: command not found


It looks like gdbus-codegen always needs to be available always to build, not just when USE=geolocation. From Source/WebCore/PlatformGTK.cmake:

    add_custom_command(
        OUTPUT ${WebCore_DERIVED_SOURCES_DIR}/AccessibilityAtspiInterfaces.h ${WebCore_DERIVED_SOURCES_DIR}/AccessibilityAtspiInterfaces.c
        DEPENDS ${WebCore_AtspiInterfaceFiles}
        COMMAND gdbus-codegen --interface-prefix=org.a11y.atspi --c-namespace=webkit --pragma-once --interface-info-header --output=${WebCore_DERIVED_SOURCES_DIR}/AccessibilityAtspiInterfaces.h ${WebCore_AtspiInterfaceFiles}
        COMMAND gdbus-codegen --interface-prefix=org.a11y.atspi --c-namespace=webkit --interface-info-body --output=${WebCore_DERIVED_SOURCES_DIR}/AccessibilityAtspiInterfaces.c ${WebCore_AtspiInterfaceFiles}
        VERBATIM
    )


I installed gdbus-codegen and the build succeeded.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2022-06-14 17:20:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e37a5481cdd16598433ce2da152471837f46ee2

commit 9e37a5481cdd16598433ce2da152471837f46ee2
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-06-14 17:16:29 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-06-14 17:20:09 +0000

    net-libs/webkit-gtk: Unconditionalize gdbus-codegen dep
    
    Also drop unnecessary dev-util/cmake dependency.
    
    Closes: https://bugs.gentoo.org/851027
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-libs/webkit-gtk/webkit-gtk-2.36.3.ebuild | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)