Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 850769 - app-backup/borgbackup-1.2.1 version bump and relax dev-python/msgpack dependency
Summary: app-backup/borgbackup-1.2.1 version bump and relax dev-python/msgpack dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL: https://github.com/borgbackup/borg/bl...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-09 16:20 UTC by Dennis Schridde
Modified: 2022-06-19 14:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2022-06-09 16:20:40 UTC
Version 1.2.1 of borgbackup was released: https://github.com/borgbackup/borg/blob/1.2.1/docs/changes.rst#version-121-2022-06-06

It allows borgbackup to be used with dev-python/msgpack-1.0.4: https://github.com/borgbackup/borg/issues/6716

In fact, the dependency in Gentoo could probably be relaxed to <dev-python/msgpack-1.0.5: https://github.com/ThomasWaldmann/borg/commit/de61d4953bfa008bfbe92f2d684b7d2c198613d9
<=dev-python/msgpack-1.0.4 would seem wrong, since that would not allow -rX releases with X>0.

Reproducible: Always
Comment 1 Piotr Karbowski (RETIRED) gentoo-dev 2022-06-10 13:00:43 UTC
The very only msgpack version that 1.2.1 borg supports is 1.0.3 and 1.0.4, thus fixing on 1.0.4 is the best way to go.
Comment 2 Dennis Schridde 2022-06-10 17:09:52 UTC
(In reply to Piotr Karbowski from comment #1)
> The very only msgpack version that 1.2.1 borg supports is 1.0.3 and 1.0.4,
> thus fixing on 1.0.4 is the best way to go.

You are right.  The PR that actually made it into the release is https://github.com/borgbackup/borg/pull/6743

That code checks for different versions:
* https://github.com/borgbackup/borg/blob/0e8c9941bb560c02aa29561d8112e270f3d282bf/setup.cfg#L41-L42
* https://github.com/borgbackup/borg/blob/0e8c9941bb560c02aa29561d8112e270f3d282bf/src/borg/helpers/msgpack.py#L142-L146
Comment 3 Larry the Git Cow gentoo-dev 2022-06-19 14:33:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8011dfe2d5fa238ee24ba2a2c323ce0952161150

commit 8011dfe2d5fa238ee24ba2a2c323ce0952161150
Author:     Piotr Karbowski <slashbeast@gentoo.org>
AuthorDate: 2022-06-19 14:26:18 +0000
Commit:     Piotr Karbowski <slashbeast@gentoo.org>
CommitDate: 2022-06-19 14:32:59 +0000

    app-backup/borgbackup: 1.2.1-r1: bump cython and msgpack deps.
    
    Closes: https://bugs.gentoo.org/850769
    Closes: https://bugs.gentoo.org/834575
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 .../{borgbackup-1.2.1.ebuild => borgbackup-1.2.1-r1.ebuild}           | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)