``` $ cat /var/tmp/portage/dev-libs/miniz-2.2.0/image/usr/share/pkgconfig/miniz.pc prefix=/usr exec_prefix=${prefix} libdir=${exec_prefix}/lib64 includedir=${prefix}/include Name: miniz Description: Version: 2.2.0 URL: Requires: Libs: -L${libdir} -lminiz Cflags: -I${includedir} ``` ``` $ s /var/tmp/portage/dev-libs/miniz-2.2.0/image/usr/include/miniz/ miniz_common.h miniz_export.h miniz.h miniz_tdef.h miniz_tinfl.h miniz_zip.h ``` So, two issues: 1. The .pc file should be in /usr/$(get_libdir)/pkgconfig/miniz.pc (not /usr/share, which is for non-libraries, etc) 2. includedir should include the miniz suffix if building as a "project" or w/e (we do this in the ebuild)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21c38cef4234688e50377827cb4b404a27618941 commit 21c38cef4234688e50377827cb4b404a27618941 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-06-03 22:46:42 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-06-04 00:05:41 +0000 dev-perl/Sereal-Decoder: add 4.23.0 Unbundles csnappy, miniz. Bug: https://bugs.gentoo.org/849578 Signed-off-by: Sam James <sam@gentoo.org> dev-perl/Sereal-Decoder/Manifest | 1 + .../Sereal-Decoder/Sereal-Decoder-4.23.0.ebuild | 79 ++++++++++++++++++++++ 2 files changed, 80 insertions(+)
Created attachment 782621 [details, diff] miniz-2.2.0-fix-pkgconfig.patch (incomplete) I did start hacking up a patch but got fed up as it didn't work for the substitution in .pc.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4c20836dad0851f6213f73f7e4be49804d9d88a commit e4c20836dad0851f6213f73f7e4be49804d9d88a Author: Matthew Smith <matthew@gentoo.org> AuthorDate: 2022-06-04 08:43:32 +0000 Commit: Matthew Smith <matthew@gentoo.org> CommitDate: 2022-06-04 19:49:19 +0000 dev-libs/miniz: pkg-config tweaks Install the pkg-config file in into the correct (architecture specific) directory, and also correct the include directory so that it behaves the same as the CMake config file. Closes: https://bugs.gentoo.org/849578 Signed-off-by: Matthew Smith <matthew@gentoo.org> dev-libs/miniz/files/miniz-2.2.0-fixincdir.patch | 18 ++++++++++++++++++ dev-libs/miniz/files/miniz-2.2.0-fixpcpath.patch | 22 ++++++++++++++++++++++ dev-libs/miniz/miniz-2.2.0-r1.ebuild | 23 +++++++++++++++++++++++ 3 files changed, 63 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb88134e0de08bf417c06beb9af45635945cc0cc commit bb88134e0de08bf417c06beb9af45635945cc0cc Author: Matthew Smith <matthew@gentoo.org> AuthorDate: 2022-06-04 09:00:40 +0000 Commit: Matthew Smith <matthew@gentoo.org> CommitDate: 2022-06-04 19:49:26 +0000 dev-perl/Sereal-Decoder: Use miniz pkg-config file Bug: https://bugs.gentoo.org/849578 Signed-off-by: Matthew Smith <matthew@gentoo.org> .../Sereal-Decoder/Sereal-Decoder-4.23.0-r1.ebuild | 61 ++++++++++++++++++++++ 1 file changed, 61 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71278d7a119fdc4d27678801ec110c0fbeebf17b commit 71278d7a119fdc4d27678801ec110c0fbeebf17b Author: Matthew Smith <matthew@gentoo.org> AuthorDate: 2022-06-04 09:00:20 +0000 Commit: Matthew Smith <matthew@gentoo.org> CommitDate: 2022-06-04 19:49:23 +0000 dev-perl/Sereal-Encoder: Use miniz pkg-config file Bug: https://bugs.gentoo.org/849578 Signed-off-by: Matthew Smith <matthew@gentoo.org> .../Sereal-Encoder/Sereal-Encoder-4.23.0-r1.ebuild | 63 ++++++++++++++++++++++ 1 file changed, 63 insertions(+)
