Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 849050 - Moving btop to the main tree?
Summary: Moving btop to the main tree?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GURU project: Trusted Committers (incl. devs)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-01 18:19 UTC by Hypoon
Modified: 2022-06-03 10:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hypoon 2022-06-01 18:19:43 UTC
As I understand it, the software started as bashtop, and then bpytop was the first rewrite, and now btop (a.k.a. btop++) is the second rewrite. Both bashtop and bpytop are in the main tree, so why not btop?

https://github.com/aristocratos/btop

It looks to me like bpytop is already discontinued in favor of btop, based solely on commit history and release history.

I do see that btop is in GURU. I'm not familiar with GURU or the process of promoting a package from GURU to the main tree.

I'm also not sure whether the proper package name should be "btop" or "btop++".
Comment 1 Florian Schmaus gentoo-dev 2022-06-03 08:51:57 UTC
@adrian Since you already maintain libstrophe in ::gentoo, it would be easy and 
 would be happy to move btop into ::gentoo if it is ok with you?
Comment 2 Adrian Schollmeyer 2022-06-03 09:00:00 UTC
I was already thinking of moving it to ::gentoo. However, I am still unsure, since btop still has a hard dependency on GCC 10 or newer (not even clang is allowed) [0]. I don't know if this might be a blocker for the quality standards of ::gentoo. Otherwise, I'd be happy to maintain it in ::gentoo.

Regarding the name: Is the + character allowed for package names? And are there some common practices on how to handle special characters at the end of package names?

[0] https://bugs.gentoo.org/839318
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-03 09:09:35 UTC
I would be very surprised if Clang didn't work. Anyway, 10 or newer is fine, 9 is EOL anyway. Commented on other bug.
Comment 4 Larry the Git Cow gentoo-dev 2022-06-03 10:51:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f95334beb5ec91c6f1356161415ce5691f76b6b3

commit f95334beb5ec91c6f1356161415ce5691f76b6b3
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2022-06-03 10:49:33 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-06-03 10:51:17 +0000

    sys-process/btop: new package, add 1.2.7, migrate from ::guru
    
    Closes: https://bugs.gentoo.org/849050
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 sys-process/btop/Manifest          |  1 +
 sys-process/btop/btop-1.2.7.ebuild | 32 ++++++++++++++++++++++++++++++++
 sys-process/btop/metadata.xml      | 16 ++++++++++++++++
 3 files changed, 49 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-06-03 10:53:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=d0b3b3702974fd32a64ee899abfa439cca3a5e0c

commit d0b3b3702974fd32a64ee899abfa439cca3a5e0c
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2022-06-03 10:53:07 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-06-03 10:53:10 +0000

    sys-process/btop: treeclean, migrated to ::gentoo
    
    Bug: https://bugs.gentoo.org/849050
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 sys-process/btop/Manifest          |  1 -
 sys-process/btop/btop-1.2.7.ebuild | 32 --------------------------------
 sys-process/btop/metadata.xml      |  8 --------
 3 files changed, 41 deletions(-)