Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 848786 - gentoo-sources-5.18 experimental patchset have incompatible project C patches
Summary: gentoo-sources-5.18 experimental patchset have incompatible project C patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Low trivial
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-31 12:03 UTC by Cihan Özakça
Modified: 2022-06-01 12:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
working patch (0009-prjc_v5.18-r1.patch,264.55 KB, patch)
2022-05-31 12:03 UTC, Cihan Özakça
Details | Diff
My kernel configuration (fixed.config,158.15 KB, text/plain)
2022-06-01 08:38 UTC, Cihan Özakça
Details
Build log (log.txt,119.16 KB, text/plain)
2022-06-01 09:06 UTC, Cihan Özakça
Details
here (alt_core.c,197.44 KB, text/x-csrc)
2022-06-01 09:47 UTC, Cihan Özakça
Details
kernel config (.config,158.89 KB, text/plain)
2022-06-01 11:14 UTC, Cihan Özakça
Details
build log (log.txt,8.96 KB, text/plain)
2022-06-01 11:14 UTC, Cihan Özakça
Details
alt-core.c (alt_core.c,197.44 KB, text/x-csrc)
2022-06-01 11:16 UTC, Cihan Özakça
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cihan Özakça 2022-05-31 12:03:26 UTC
Created attachment 781637 [details, diff]
working patch

Cannot build gentoo-sources-5.18.1-r1 when PDS Scheduler enabled which added when experimental use flag is enabled. im adding the project C patches from TKG's patchset which is compatible with this kernel.
Comment 1 Mike Pagano gentoo-dev 2022-05-31 12:08:02 UTC
There is no difference between that patch and the one I committed.

https://dev.gentoo.org/~mpagano/genpatches/trunk/5.18/5020_BMQ-and-PDS-io-scheduler-v5.18-r1.patch
Comment 2 Mike Pagano gentoo-dev 2022-05-31 12:18:37 UTC
No problems here with:

#
CONFIG_SCHED_ALT=y
# CONFIG_SCHED_BMQ is not set
CONFIG_SCHED_PDS=y


Maybe attaching your.config might be more helpful ?
Comment 3 Cihan Özakça 2022-06-01 08:37:09 UTC
(In reply to Mike Pagano from comment #2)
> No problems here with:
> 
> #
> CONFIG_SCHED_ALT=y
> # CONFIG_SCHED_BMQ is not set
> CONFIG_SCHED_PDS=y
> 
> 
> Maybe attaching your.config might be more helpful ?

So maybe youre right there is a problem with my configuration. Interesting thing is same configuration works with the patch ive submitted.
Comment 4 Cihan Özakça 2022-06-01 08:38:10 UTC
Created attachment 781928 [details]
My kernel configuration
Comment 5 Cihan Özakça 2022-06-01 08:40:10 UTC
I tried to build gentoo-sources with experimental use flag two times both failed. I dont know whats happening, sorry for the inconvenience.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-01 08:40:30 UTC
(In reply to Cihan Özakça from comment #5)
> I tried to build gentoo-sources with experimental use flag two times both
> failed. I dont know whats happening, sorry for the inconvenience.

Please include the full log of it failing.
Comment 7 Cihan Özakça 2022-06-01 09:06:11 UTC
Created attachment 781931 [details]
Build log
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-01 09:20:48 UTC
your config says 5.18.0, but 5.18.1-r1 is the working one. Could you upload kernel/sched/alt_core.c please?

Are you sure you haven't forgotten to update your symlink via e.g. eselect kernel?
Comment 9 Cihan Özakça 2022-06-01 09:43:32 UTC
(In reply to Sam James from comment #8)
> your config says 5.18.0, but 5.18.1-r1 is the working one. Could you upload
> kernel/sched/alt_core.c please?
> 
> Are you sure you haven't forgotten to update your symlink via e.g. eselect
> kernel?

Let me double check.
Comment 10 Cihan Özakça 2022-06-01 09:47:48 UTC
Created attachment 781937 [details]
here
Comment 11 Mike Pagano gentoo-dev 2022-06-01 11:07:30 UTC
(In reply to Cihan Özakça from comment #10)
> Created attachment 781937 [details]
> here

Can you upload the proper .config , please?

This one does not have the patch applied. I cannot see SCHED_ALT, for example.
Comment 12 Cihan Özakça 2022-06-01 11:14:21 UTC
Created attachment 781961 [details]
kernel config
Comment 13 Cihan Özakça 2022-06-01 11:14:50 UTC
Created attachment 781964 [details]
build log
Comment 14 Cihan Özakça 2022-06-01 11:16:48 UTC
Created attachment 781967 [details]
alt-core.c
Comment 15 Larry the Git Cow gentoo-dev 2022-06-01 12:14:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82a8be8d38b87bd74e37965de591b725e63cc33b

commit 82a8be8d38b87bd74e37965de591b725e63cc33b
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2022-06-01 12:13:14 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2022-06-01 12:13:14 +0000

    sys-kernel/gentoo-sources: Fix for BMQ/PDS patch
    
    If you don't use the alternate schedulars BMQ/PDS enabled
    with the 'experimental' use flag then there is no need
    to update.
    
    Closes: https://bugs.gentoo.org/848786
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 sys-kernel/gentoo-sources/Manifest                 |  3 +++
 .../gentoo-sources/gentoo-sources-5.18.1-r2.ebuild | 28 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)