Hi systemd team, I'm coming here from bug #847268. Related to function udev_reload I noticed that: - Many ebuilds only call udev_reload from pkg_postinst but not from pkg_postrm and the docs of function udev_reload in the eclass do not say when or when not to call udev_reload. I'd personally expect a call from pkg_postrm as well but I'm not sure, and I found others not doing that. - The example code in the eclass header does not use udev_reload anywhere but it could, and my vote for it. I'm happy to make a pull request for review once I understand what the requirements are, but feel free to take over implementation, if you like. Thanks and best, Sebastian
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b977bfdb07b76e108bd962c998421353a40e131 commit 9b977bfdb07b76e108bd962c998421353a40e131 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2022-06-04 13:47:29 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2022-06-08 00:24:56 +0000 udev.eclass: document when udev_reload should be called Closes: https://bugs.gentoo.org/847436 Signed-off-by: Mike Gilbert <floppym@gentoo.org> eclass/udev.eclass | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae1fda4dc09564cba28db147d4c682e0397756ff commit ae1fda4dc09564cba28db147d4c682e0397756ff Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2022-06-04 14:18:07 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2022-06-08 00:24:58 +0000 install-qa-check.d/60udev-eclass: check for udev_reload in pkg_postrm Bug: https://bugs.gentoo.org/847436 Signed-off-by: Mike Gilbert <floppym@gentoo.org> metadata/install-qa-check.d/60udev-eclass | 5 +++++ 1 file changed, 5 insertions(+)
Very nice, thank you!
