Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 847229 - app-misc/inputlircd-0.0.1_pre15-r3: inverted version test
Summary: app-misc/inputlircd-0.0.1_pre15-r3: inverted version test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-24 09:06 UTC by Manuel Lauss
Modified: 2022-05-27 15:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Lauss 2022-05-24 09:06:34 UTC
The intent is to apply a patch when sys-kernel/linux-headers are 4.4 or above;
the test in -r3 tests whether "4.4" is equal or higher than header version,
which is the inverse of what was in -r2, which resulted in a working version.

The package built by -r3 does not work correctly, while -r2 does.

A patch like this fixes it for me:

--- app-misc/inputlircd/inputlircd-0.0.1_pre15-r3.ebuild~       2022-05-02 09:00:46.000000000 +0200
+++ app-misc/inputlircd/inputlircd-0.0.1_pre15-r3.ebuild        2022-05-24 11:03:03.535912693 +0200
@@ -16,7 +16,7 @@ KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~ia6
 src_prepare() {
        local ver="$(best_version sys-kernel/linux-headers)"
        ver=${ver#sys-kernel/linux-headers-}
-       if ver_test 4.4 -ge ${ver}; then
+       if ver_test ${ver} -ge 4.4; then
                eapply "${FILESDIR}/inputlircd-linux-4.4-fix.patch"
        fi
Comment 1 Larry the Git Cow gentoo-dev 2022-05-27 15:36:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=30b29b940c9e30369137c1aadb6a1c1ab56ce371

commit 30b29b940c9e30369137c1aadb6a1c1ab56ce371
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-05-27 15:35:25 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-05-27 15:35:25 +0000

    app-misc/inputlircd: fix kernel headers version test
    
    Closes: https://bugs.gentoo.org/847229
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 app-misc/inputlircd/inputlircd-0.0.1_pre15-r3.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)