Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 846971 - =www-client/firefox-91.9.0 fails to compile with gcc-12
Summary: =www-client/firefox-91.9.0 fails to compile with gcc-12
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks: gcc-12
  Show dependency tree
 
Reported: 2022-05-22 09:38 UTC by tt_1
Modified: 2022-06-01 14:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output from emerge --info (emerge-info,5.69 KB, text/plain)
2022-05-22 09:41 UTC, tt_1
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2022-05-22 09:38:30 UTC
firefox-91.9.0 cannot be compiled with gcc-12: 


4:12.07 warning: src/vector_type.h:503:11: warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of type 'struct glsl::vec4' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
4:12.07 warning: 503 | memcpy(&v, p, sizeof(v));
4:12.07 warning: | ^
4:12.07 warning: src/glsl.h:1796:8: note: 'struct glsl::vec4' declared here
4:12.07 warning: 1796 | struct vec4 {
4:12.07 warning: | ^~~~
4:12.07 error: failed to run custom build command for swgl v0.1.0 (/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/swgl)
4:12.07 Caused by:
4:12.07 process didn't exit successfully: /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/release/build/swgl-53ad59f3596d2082/build-script-build (exit status: 1)
4:12.07 --- stdout
4:12.07 cargo:rerun-if-changed=/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res/brush_blend.glsl
4:12.07 cargo:rerun-if-changed=/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res/shared.glsl
4:12.07 cargo:rerun-if-changed=/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res/base.glsl
4:12.07 cargo:rerun-if-changed=/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res/prim_shared.glsl
4:12.07 cargo:rerun-if-changed=/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res/rect.glsl
4:12.09 cargo:rerun-if-changed=/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res/render_task.glsl
4:12.09 cargo:rerun-if-changed=/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res/gpu_cache.glsl

4:14.26 cargo:warning=src/blend.h:53:39: required from here
4:14.26 cargo:warning=src/vector_type.h:503:11: warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of type 'struct glsl::vec4' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
4:14.26 cargo:warning= 503 | memcpy(&v, p, sizeof(v));
4:14.26 cargo:warning= | ^
4:14.26 cargo:warning=src/glsl.h:1796:8: note: 'struct glsl::vec4' declared here
4:14.26 cargo:warning= 1796 | struct vec4 {
4:14.26 cargo:warning= | ^~~~
4:14.26 exit status: 1
4:14.26 --- stderr
4:14.26 error occurred: Command "/usr/bin/armv7a-unknown-linux-gnueabihf-g++" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-march=armv7-a" "-mfpu=vfpv3-d16" "-mfpu=neon-vfpv4" "-mthumb" "-mfloat-abi=hard" "--sysroot" "/usr/armv7a-unknown-linux-gnueabihf" "-I/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/dist/stl_wrappers" "-I/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/dist/system_wrappers" "-include" "/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/config/gcc_hidden.h" "-U_FORTIFY_SOURCE" "-D_FORTIFY_SOURCE=2" "-fstack-protector-strong" "-DNDEBUG=1" "-DTRIMMED=1" "-I/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/toolkit/library/rust" "-I/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/toolkit/library/rust" "-I/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/dist/include" "-I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nspr" "-I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nss" "-I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nspr" "-I/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/dist/include/nss" "-I/usr/armv7a-unknown-linux-gnueabihf/usr/include" "-I/usr/armv7a-unknown-linux-gnueabihf/usr/include/pixman-1" "-DMOZILLA_CLIENT" "-include" "/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/mozilla-config.h" "-Wall" "-Wempty-body" "-Wignored-qualifiers" "-Wpointer-arith" "-Wsign-compare" "-Wtype-limits" "-Wunreachable-code" "-Wno-invalid-offsetof" "-Wc++2a-compat" "-Wduplicated-cond" "-Wimplicit-fallthrough" "-Wno-error=maybe-uninitialized" "-Wno-error=deprecated-declarations" "-Wno-error=array-bounds" "-Wno-error=coverage-mismatch" "-Wno-error=free-nonheap-object" "-Wno-multistatement-macros" "-Wno-error=class-memaccess" "-Wno-error=deprecated-copy" "-Wno-error=unused-but-set-variable" "-Wformat" "-Wformat-security" "-Wformat-overflow=2" "-Wno-psabi" "-fno-sized-deallocation" "-fno-aligned-new" "-pipe" "-fomit-frame-pointer" "-fno-tree-loop-vectorize" "-mthumb" "-mno-thumb-interwork" "-mfpu=neon" "-mfloat-abi=hard" "-fno-exceptions" "-fno-strict-aliasing" "-fPIC" "-fno-rtti" "-ffunction-sections" "-fdata-sections" "-fno-exceptions" "-fno-math-errno" "-pthread" "-pipe" "-O2" "-fomit-frame-pointer" "-funwind-tables" "-DMOZILLA_CONFIG_H" "-I" "/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox-91.9.0/gfx/wr/webrender/res" "-I" "src" "-I" "/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/thumbv7neon-unknown-linux-gnueabihf/release/build/swgl-6f1cac2951111a0b/out" "-std=c++17" "-fno-exceptions" "-fno-rtti" "-fno-math-errno" "-UMOZILLA_CONFIG_H" "-D_GLIBCXX_USE_CXX11_ABI=0" "-o" "/usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-91.9.0/work/firefox_build/thumbv7neon-unknown-linux-gnueabihf/release/build/swgl-6f1cac2951111a0b/out/src/gl.o" "-c" "src/gl.cc" with args "armv7a-unknown-linux-gnueabihf-g++" did not execute successfully (status code exit status: 1).
4:14.26 warning: build failed, waiting for other jobs to finish...
Comment 1 tt_1 2022-05-22 09:41:10 UTC
Created attachment 780131 [details]
output from emerge --info
Comment 2 tt_1 2022-05-22 11:27:49 UTC
these two fixes are needed to compile 91esr with gcc-12: 

https://hg.mozilla.org/mozilla-central/rev/8af9ccb50f19
https://hg.mozilla.org/mozilla-central/rev/00128c425ebb

they apply cleanly on top of 91.9.1


the build.log is full of warnings and has 46mb, I was unable to get it down to the allowed maximum of 1000kb ; but the paste from my first post should be sufficent to understand the problem
Comment 3 Sven B. 2022-05-23 13:52:54 UTC
The same applies to thunderbird-91.9.1
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-30 07:20:29 UTC
(In reply to tt_1 from comment #2)
> these two fixes are needed to compile 91esr with gcc-12: 
> 
> https://hg.mozilla.org/mozilla-central/rev/8af9ccb50f19
> https://hg.mozilla.org/mozilla-central/rev/00128c425ebb
> 
> they apply cleanly on top of 91.9.1
> 
> 
> the build.log is full of warnings and has 46mb, I was unable to get it down
> to the allowed maximum of 1000kb ; but the paste from my first post should
> be sufficent to understand the problem

Could you please request a backport on the upstream bug?
Comment 5 Joonas Niilola gentoo-dev 2022-05-30 07:22:55 UTC
I'm aware of the bug with gcc-12, we can add these patches to everyone by updating our FIREFOX_PATCHSET. New releases are out tomorrow, so I didn't bother patching the current ones - as gcc-12 is still keywords-masked.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-31 04:41:33 UTC
(In reply to Joonas Niilola from comment #5)
> I'm aware of the bug with gcc-12, we can add these patches to everyone by
> updating our FIREFOX_PATCHSET. New releases are out tomorrow, so I didn't
> bother patching the current ones - as gcc-12 is still keywords-masked.

Sure, not hurrying you, more that I just wanted to ask someone who hit it (I don't use firefox ESR on boxes w/ gcc 12) to ask for a backport upstream because they don't seem to do it for a lot of stuff unless you ask.

But if you're happy to add it before that, that's even better! Thank you!
Comment 7 Larry the Git Cow gentoo-dev 2022-06-01 10:40:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=378e151bc78d66639de234f4d17f1703164ecc6d

commit 378e151bc78d66639de234f4d17f1703164ecc6d
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-06-01 10:39:47 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-06-01 10:40:17 +0000

    www-client/firefox: add 91.10.0
    
     - bump EAPI to 8,
     - add upstream patches to fix gcc-12 build on esr.
    
    Closes: https://bugs.gentoo.org/846971
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest               |   99 +++
 www-client/firefox/firefox-91.10.0.ebuild | 1244 +++++++++++++++++++++++++++++
 2 files changed, 1343 insertions(+)
Comment 8 Larry the Git Cow gentoo-dev 2022-06-01 14:46:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d81f2a0fb4990b1e005108d89337401cd181fd09

commit d81f2a0fb4990b1e005108d89337401cd181fd09
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-06-01 14:37:23 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-06-01 14:46:38 +0000

    mail-client/thunderbird: add 91.10.0
    
     - bump EAPI to 8,
     - add upstream patches to fix gcc-12 build.
    
    Bug: https://bugs.gentoo.org/846971
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird/Manifest                   |   65 ++
 mail-client/thunderbird/thunderbird-91.10.0.ebuild | 1139 ++++++++++++++++++++
 2 files changed, 1204 insertions(+)