Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 846578 - games-emulation/dolphin: Trying to remove existing mgba dir in 9999 ebuild
Summary: games-emulation/dolphin: Trying to remove existing mgba dir in 9999 ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-20 15:20 UTC by Jonas Rakebrandt
Modified: 2022-05-20 17:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Rakebrandt 2022-05-20 15:20:22 UTC 
In `src_prepare` the ebuild tries to remove the `Externals/mGBA/mgba` dir and replace it with the fixed commit version.
This fails in the 9999 version of the ebuild because that dir is already pulled in via `EGIT_SUBMODULES`.

A fix would be to simply extend the if statement with:

`if use mgba && [[ ${PV} != *9999 ]]; then`
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-05-20 17:12:39 UTC 
Thanks!
Comment 2 Larry the Git Cow gentoo-dev 2022-05-20 17:13:47 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb0768f7aaa59b762014a303218eda57dce2ed1c

commit bb0768f7aaa59b762014a303218eda57dce2ed1c
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-05-20 17:13:21 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-05-20 17:13:21 +0000

    games-emulation/dolphin: Do not remove mgba in 9999
    
    Thanks to xarblu for the suggestion.
    
    Closes: https://bugs.gentoo.org/846578
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-emulation/dolphin/dolphin-5.0_p20220520.ebuild | 2 +-
 games-emulation/dolphin/dolphin-9999.ebuild          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)