Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 844190 - www-misc/monitorix missing dependency on dev-perl/XML-LibXML
Summary: www-misc/monitorix missing dependency on dev-perl/XML-LibXML
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Pedro
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-05-14 13:53 UTC by Jose Roberto
Modified: 2022-11-22 13:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Roberto 2022-05-14 13:53:26 UTC
Although www-misc/monitorix builds successfully, the bind module of monitorix depends on dev-perl/XML-LibXML. See the log messages (before installing XML-LibXML):

# tail -f /var/log/monitorix
"unable to load module 'bind'. Can't locate XML/LibXML.pm"

After installing the dev-perl/XML-LibXML the bind graphs are available. 




Reproducible: Always

Steps to Reproduce:
1. Install www-misc/monitorix
2. Enable the bind module in /etc/monitorix/monitorix.conf
3. Access the monitorix web interface
Actual Results:  
The bind graphs are missing.

Expected Results:  
The bind graphs should not be missing.

I suggest adding XML/LibXML.pm as a dependency of www-misc/monitorix.
Comment 1 Pedro 2022-05-19 09:59:30 UTC
This was already discussed and removed on a previous bug/PR (https://bugs.gentoo.org/511122).

dev-perl/XML-LibXML its an optional dependency and thus it shouldn't be included in the ebuild itself. I could add it as part of the post install messages, but there are a lot of dependencies depending on the configuration. Right now I'm not 100% sure if that's the best approach, since adding all dependencies to the post install message might trigger the oposite effect and the user might not read it all, since it has a lot of info.

I'll keep the bug open and think about the best course of action, to see if I can find a better solution.
Comment 2 Joonas Niilola gentoo-dev 2022-05-19 10:17:32 UTC
You should list them all as optfeature. 
See https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-process/glances/glances-3.2.4.2.ebuild#n65
Comment 4 Pedro 2022-05-23 20:02:18 UTC
The thing is that I believe the list could be quite long, but yeah I also think we should document all of them. It will take me a while though.
Comment 5 Jose Roberto 2022-05-23 20:57:50 UTC
I believe that the optfeature suggestion is also the best. Do you known what Debian/Ubuntu install when you run "apt-get install monitorix" (I did not check the command)?

Also: I also believe that the new optfeatures to the monitorix ebuild should be implemented by demand. I have experienced another missing package (related with the postgresql module), but installing that did not fix the problem entirely. In other words: maybe add a lot of optfeatures will trigger new problems!
Comment 6 Pedro 2022-05-24 20:49:49 UTC
Debian or Ubuntu install all as a big binary package, so there is no point on comparison.

Regarding the optfeature, its an eclass that allows you to advertise optional functionality that might be useful to users, it doesn't install anything per se, just checks the associated packages in the call and in case the user is missing the ones that trigger the message, it will display the message.

I talked with Monitorix's developer and he told me about a recent bug in PostgreSQL in which you could get an error if trying to check the DB parameters with an unprivileged user, could you confirm if this is your case of its a different issue?
Comment 7 Jose Roberto 2022-05-24 23:27:49 UTC
Yes, I am experiencing problems with my unprivileged user. But I do not remember what package was missing =(
Comment 8 Larry the Git Cow gentoo-dev 2022-11-22 13:26:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff06f996918b56f8f887578d2fbe0b6ae15088b8

commit ff06f996918b56f8f887578d2fbe0b6ae15088b8
Author:     Pedro Arizmendi <dwosky@pm.me>
AuthorDate: 2022-11-07 14:39:32 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-11-22 13:26:03 +0000

    www-misc/monitorix: Added packages and dependencies needed.
    
    Added possible packages and dependencies needed for some configuration options.
    
    Closes: https://bugs.gentoo.org/844190
    Signed-off-by: Pedro Arizmendi <dwosky@pm.me>
    Closes: https://github.com/gentoo/gentoo/pull/28166
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 ...ix-3.14.0.ebuild => monitorix-3.14.0-r1.ebuild} | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)