"config.h" file not found during Polkit build script when USE="test" tests are enabled. I am the second of two people to reproduce this. It should be straightforward to reproduce. I am on a fully updated amd64 system Reproducible: Always
Created attachment 777989 [details] build.log with USE=test - fatal error config.h file not found I use a bashrc script that prints meson-configure and meson-options, but that is irrelevant. I also used "-Wno-deprecated-declarations" because there was a lot of spam from that, making it difficult to read. Tried the normal way, doesnt affect the behavior.
Note that the test USE flag is never used to control _running_ tests anyway, but FEATURES=test is (which toggles the flag). And tests in this ebuild are restricted for exactly this reason, so FEATURES=test won't turn it on. So, the only people who are affected by this are people setting USE=test manually (which you shouldn't do, and it's pointless), right?
(In reply to Sam James from comment #2) > Note that the test USE flag is never used to control _running_ tests anyway, > but FEATURES=test is (which toggles the flag). And tests in this ebuild are > restricted for exactly this reason, so FEATURES=test won't turn it on. > > So, the only people who are affected by this are people setting USE=test > manually (which you shouldn't do, and it's pointless), right? To expand a bit, I think there's two issues: 1. The musl patch needs adjusting to just handle meson and not add a config.h include (file won't exist anymore); 2. Upstream don't produce proper dist tarballs with the needed deps for tests. I think we can fix 1 when using snapshots, so let's do that, but combine it with a newer snapshot to make life easier.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99b60e69496c865e2b8103804b45ecf92c02fb94 commit 99b60e69496c865e2b8103804b45ecf92c02fb94 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-05-11 05:21:33 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-05-11 05:26:11 +0000 sys-auth/polkit: add 0.120_p20220509 (unkeyworded) Unkeyworded for now until tomorrow probably. (Nothing major changed but it's late/early and I don't want to take a risk and then go to bed.) (In terms of the snapshot, the only notable things are that upstream dropped autotools, but we were using meson for a little while now anyway, and a bunch of the patches we were including to a previous snapshot are now rolled into this one.) I'd not bothered looking much into the test situation given the bug flagged in the ebuild (the dist tarballs don't contain the test dependencies needed and they don't use meson subprojects so we can't provide them ourselves either) ... but a bug (with a dodgy premise -- because you shouldn't be setting USE=test manually anyway; RESTRICT="test" is currently in ebuild anyhow) exposed the fact that if you _do_ try to run tests right now, they end up failing because of our musl patch which still includes config.h even though we're doing a meson build. So, a double win: 1. Tests are now wired up and run for snapshots at least! Yay! 2. Our musl patch is now cleaner and ready for another attempt at upstream submission. Closes: https://bugs.gentoo.org/843647 Signed-off-by: Sam James <sam@gentoo.org> sys-auth/polkit/Manifest | 1 + ..._p20220509-make-netgroup-support-optional.patch | 231 +++++++++++++++++++++ sys-auth/polkit/polkit-0.120_p20220509.ebuild | 146 +++++++++++++ 3 files changed, 378 insertions(+)
