Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 843629 - =media-libs/libjxl-0.7.0_pre20220329 fails to cross compile to aarch64 with: transform/palette.h:124:20: error: variable ‘std::atomic<int> num_errors’ has initializer but incomplete type
Summary: =media-libs/libjxl-0.7.0_pre20220329 fails to cross compile to aarch64 with: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Novomeský
URL: https://github.com/libjxl/libjxl/comm...
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2022-05-10 19:55 UTC by tt_1
Modified: 2022-05-14 01:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
compressed build log from aarch64-cross (aarch64-build.log.gz,5.17 KB, application/gzip)
2022-05-10 19:55 UTC, tt_1
Details
output from emerge --info (aarch64) (emerge-info,5.37 KB, text/plain)
2022-05-10 19:56 UTC, tt_1
Details
enough to make if fly (0001-fix-missing-include-aarch64.patch,754 bytes, patch)
2022-05-10 19:57 UTC, tt_1
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2022-05-10 19:55:26 UTC
Created attachment 777977 [details]
compressed build log from aarch64-cross

just found this beauty when cross compiling libs for aarch64:

In file included from /usr/aarch64-unknown-linux-gnu/tmp/portage/media-libs/libjxl-0.7.0_pre20220329/work/libjxl-libjxl-fde214c/lib/jxl/modular/transform/transform.cc:11:
/usr/aarch64-unknown-linux-gnu/tmp/portage/media-libs/libjxl-0.7.0_pre20220329/work/libjxl-libjxl-fde214c/lib/jxl/modular/transform/palette.h: In function ‘jxl::Status jxl::InvPalette(jxl::Image&, uint32_t, uint32_t, uint32_t, jxl::Predictor, const jxl::weighted::Header&, jxl::ThreadPool*)’:
/usr/aarch64-unknown-linux-gnu/tmp/portage/media-libs/libjxl-0.7.0_pre20220329/work/libjxl-libjxl-fde214c/lib/jxl/modular/transform/palette.h:124:20: error: variable ‘std::atomic<int> num_errors’ has initializer but incomplete type
  124 |   std::atomic<int> num_errors{0};
      |                    ^~~~~~~~~~
Comment 1 tt_1 2022-05-10 19:56:29 UTC
Created attachment 777980 [details]
output from emerge --info (aarch64)
Comment 2 tt_1 2022-05-10 19:57:31 UTC
Created attachment 777983 [details, diff]
enough to make if fly
Comment 3 tt_1 2022-05-10 19:59:12 UTC
the issue is already fixed in git by adding one missing include to I believe seven individual files, but its also possible to pull in the full patch from the posted URL
Comment 4 Daniel Novomeský 2022-05-10 20:15:28 UTC
libjxl-0.7.0_pre20220329 is a snapshot.

I think that instead of patching the older snapshot we could simply move to a newer snapshot where the issue is fixed.
Comment 5 tt_1 2022-05-10 20:18:40 UTC
thats also possible, if you feel like taring up a new snapshot. patch is very minimal though, and no need to add -r1 if it fixes a build error. 

pick your poison! :-)
Comment 6 Larry the Git Cow gentoo-dev 2022-05-14 01:02:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f4d5c2477709118c9d59c90ccc49d540a7dd69cd

commit f4d5c2477709118c9d59c90ccc49d540a7dd69cd
Author:     Daniel Novomesky <dnovomesky@gmail.com>
AuthorDate: 2022-05-11 16:02:57 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-14 01:02:23 +0000

    media-libs/libjxl: version bump to 20220511 snapshot
    
    - Drop old 0.7.0_pre20220311
    - Depend on media-libs/libjpeg-turbo instead virtual/jpeg
    - -DCMAKE_SKIP_RPATH=ON is no longer needed
    
    Closes: https://bugs.gentoo.org/843629
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Daniel Novomesky <dnovomesky@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/25447
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/libjxl/Manifest                         |   2 +-
 media-libs/libjxl/files/libjxl-0.7.0-atomic.patch  | 136 ---------------------
 ...0311.ebuild => libjxl-0.7.0_pre20220511.ebuild} |  31 ++---
 media-libs/libjxl/libjxl-9999.ebuild               |   3 +-
 4 files changed, 10 insertions(+), 162 deletions(-)