Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 843422 - dev-libs/marisa-0.2.6 fails 'base-test' test on stable sparc
Summary: dev-libs/marisa-0.2.6 fails 'base-test' test on stable sparc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: Sparc64 Linux
: Normal normal
Assignee: Arfrever Frehtes Taifersar Arahesis
URL:
Whiteboard:
Keywords: PullRequest, TESTFAILURE
Depends on:
Blocks:
 
Reported: 2022-05-09 13:46 UTC by Agostino Sarubbo
Modified: 2022-06-23 04:29 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,107.55 KB, text/plain)
2022-05-09 13:46 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-05-09 13:46:34 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/marisa-0.2.6 fails tests on stable sparc.
Discovered on: sparc (internal ref: sparc_at)
Comment 1 Agostino Sarubbo gentoo-dev 2022-05-09 13:46:36 UTC
Created attachment 777770 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-11 01:14:58 UTC
Please include test-suite.log.
Comment 3 Agostino Sarubbo gentoo-dev 2022-05-17 09:31:18 UTC
========================================
   marisa 0.2.6: tests/test-suite.log
========================================

# TOTAL: 5
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: base-test
===============

base-test.cc:14: TestTypes(): 21: Assertion `MARISA_WORD_SIZE == (sizeof(std::size_t) * 8)' failed.
FAIL base-test (exit status: 255)
Comment 4 matoro archtester 2022-06-23 04:03:21 UTC
I've pushed a fix upstream:  https://github.com/s-yata/marisa-trie/pull/46

But given that upstream is dead, and we already have to pull in identical patches for riscv and loong, I think it's safe to anticipate the same will be required here.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-23 04:09:31 UTC
(In reply to matoro from comment #4)
> I've pushed a fix upstream:  https://github.com/s-yata/marisa-trie/pull/46
> 
> But given that upstream is dead, and we already have to pull in identical
> patches for riscv and loong, I think it's safe to anticipate the same will
> be required here.

More than safe to backport. Please go ahead!

(feel free to open PRs or ping me if you're not sure what "the line" is)
Comment 6 Larry the Git Cow gentoo-dev 2022-06-23 04:29:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6fa63e32cc33b26430dfcd01eec8cad219ab68a

commit e6fa63e32cc33b26430dfcd01eec8cad219ab68a
Author:     matoro <matoro@users.noreply.github.com>
AuthorDate: 2022-06-23 04:05:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-23 04:29:48 +0000

    dev-libs/marisa: fix build on 64-bit sparc
    
    See: https://github.com/gentoo/gentoo/commit/ddedb2650b0beb769a2e165681be5a99a46cfac8
    See: https://github.com/gentoo/gentoo/commit/78057fe9e8fb2c1a89ff10dba205f2b40b009090
    Closes: https://bugs.gentoo.org/843422
    Signed-off-by: matoro <matoro@users.noreply.github.com>
    Closes: https://github.com/gentoo/gentoo/pull/26050
    Signed-off-by: Sam James <sam@gentoo.org>

 .../marisa/files/marisa-0.2.6-sparc64_word_size.patch    | 16 ++++++++++++++++
 dev-libs/marisa/marisa-0.2.6.ebuild                      |  1 +
 2 files changed, 17 insertions(+)