Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 843386 - media-gfx/gimp-9999 - gimp-2.10_fix_test-appdata.patch fails to apply
Summary: media-gfx/gimp-9999 - gimp-2.10_fix_test-appdata.patch fails to apply
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-05-09 06:03 UTC by jospezial
Modified: 2022-07-13 03:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,21.34 KB, text/plain)
2022-05-09 06:04 UTC, jospezial
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2022-05-09 06:03:13 UTC
There were some upstream changes to desktop/test-appdata.sh.in in the last days:
https://gitlab.gnome.org/GNOME/gimp/-/commits/master/desktop/test-appdata.sh.in

Please check whether gimp-2.10_fix_test-appdata.patch is obsolete or needs to be  rebased.
Comment 1 jospezial 2022-05-09 06:04:31 UTC
Created attachment 777659 [details]
build.log
Comment 2 Sergey Torokhov 2022-05-13 17:35:44 UTC
Patching in place with installed dev-libs/apstream results in failed tests too.
I'm thinking about disabling this test.
Comment 3 Sergey Torokhov 2022-05-15 22:15:59 UTC
After drop this test the tests currently are failed due to some changes in "po" directory:

```
>>> Test phase: media-gfx/gimp-9999
 * Scanning for an open DISPLAY to start Xvfb ...
 * Starting Xvfb on $DISPLAY=1 ...
make -j4 check 
make  check-recursive
make[1]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999'
Making check in m4macros
make[2]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/m4macros'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/m4macros'
Making check in cursors
make[2]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/cursors'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/cursors'
Making check in themes
make[2]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/themes'
Making check in System
make[3]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/themes/System'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/themes/System'
make[3]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/themes'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/themes'
make[2]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/themes'
Making check in po
make[2]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/po'
INTLTOOL_EXTRACT="/usr/bin/intltool-extract" XGETTEXT="/usr/bin/xgettext" srcdir=. /usr/bin/intltool-update --gettext-package gimp30 --pot
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
if [ -r missing -o -r notexist ]; then \
  exit 1; \
fi
make[2]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/po'
Making check in po-libgimp
make[2]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/po-libgimp'
INTLTOOL_EXTRACT=/usr/bin/intltool-extract srcdir=. /usr/bin/intltool-update --gettext-package gimp30-libgimp --pot
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
if [ -r missing -o -r notexist ]; then \
  exit 1; \
fi
make[2]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/po-libgimp'
Making check in po-plug-ins
make[2]: Entering directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/po-plug-ins'
INTLTOOL_EXTRACT=/usr/bin/intltool-extract srcdir=. /usr/bin/intltool-update --gettext-package gimp30-std-plug-ins --pot
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
The following files contain translations and are currently not in use. Please
consider adding these to the POTFILES.in file, located in the po/ directory.

plug-ins/file-fli/fli.c

If some of these files are left out on purpose then please add them to
POTFILES.skip instead of POTFILES.in. A file 'missing' containing this list
of left out files has been written in the current directory.
Please report to https://gitlab.gnome.org/GNOME/gimp/issues/new
if [ -r missing -o -r notexist ]; then \
  exit 1; \
fi
make[2]: *** [Makefile:365: check] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999/po-plug-ins'
make[1]: *** [Makefile:876: check-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-gfx/gimp-9999/work/gimp-9999'
make: *** [Makefile:1174: check] Error 2
emake failed

```
Comment 4 Sergey Torokhov 2022-06-04 23:48:49 UTC
Related upstream issue: https://gitlab.gnome.org/GNOME/gimp/-/issues/8235
Comment 5 jospezial 2022-07-08 07:56:28 UTC
Unfortunately no progress on the upstream bug.
Is there any way to shortly make media-gfx/gimp-9999 emerge-able again?
Comment 6 Sergey Torokhov 2022-07-11 22:27:58 UTC
It's strange but today I can't reproduced test issue so just will update live-ebuild with disabling apdata-test.
Comment 7 Larry the Git Cow gentoo-dev 2022-07-11 22:50:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=351005d4ebc1faf738ddb202eb70d4490429e97f

commit 351005d4ebc1faf738ddb202eb70d4490429e97f
Author:     Sergey Torokhov <torokhov-s-a@yandex.ru>
AuthorDate: 2022-07-11 22:20:18 +0000
Commit:     John Helmert III <ajak@gentoo.org>
CommitDate: 2022-07-11 22:48:01 +0000

    media-gfx/gimp: 9999, disable appdata-test
    
    Closes: https://bugs.gentoo.org/843386
    
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Closes: https://github.com/gentoo/gentoo/pull/26355
    Signed-off-by: John Helmert III <ajak@gentoo.org>

 media-gfx/gimp/gimp-9999.ebuild | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
Comment 8 jospezial 2022-07-13 03:23:51 UTC
Thank you. It works now.