Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 842498 - sys-block/open-iscsi-2.1.6: systemd unit files are broken
Summary: sys-block/open-iscsi-2.1.6: systemd unit files are broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-05-03 22:19 UTC by Alec Moskvin
Modified: 2022-05-03 22:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Moskvin 2022-05-03 22:19:03 UTC
Current version installs unit files with placeholders in place, e.g.:

ExecStart=@SBINDIR@/iscsid -f

Reproducible: Always

Steps to Reproduce:
1. emerge =sys-block/open-iscsi-2.1.6
2. systemctl start iscsid
Actual Results:  
systemd[1]: /lib/systemd/system/iscsid.service:13: Neither a valid executable name nor an absolute path: SBINDIR@/iscsid

Expected Results:  
Service should start successfully
Comment 1 Larry the Git Cow gentoo-dev 2022-05-03 22:45:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19bb7cb9303bb3f4e349eee23c0a38309d7bf9d6

commit 19bb7cb9303bb3f4e349eee23c0a38309d7bf9d6
Author:     Alec Moskvin <alecm@gmx.com>
AuthorDate: 2022-05-03 22:18:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-03 22:45:07 +0000

    sys-block/open-iscsi: Use placeholder susbstitution from Makefile
    
    Closes: https://bugs.gentoo.org/842498
    Signed-off-by: Alec Moskvin <alecm@gmx.com>
    Closes: https://github.com/gentoo/gentoo/pull/25309
    Signed-off-by: Sam James <sam@gentoo.org>

 ...csi-2.1.6.ebuild => open-iscsi-2.1.6-r1.ebuild} | 23 +++++++---------------
 1 file changed, 7 insertions(+), 16 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2022-05-03 22:50:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe6a8a1eaaf829a5246c3e101a5f47a9e2a1e96b

commit fe6a8a1eaaf829a5246c3e101a5f47a9e2a1e96b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-03 22:49:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-03 22:50:16 +0000

    sys-block/open-iscsi: use systemd_get_utildir
    
    Bug: https://bugs.gentoo.org/842498
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-block/open-iscsi/open-iscsi-2.1.6-r1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 Alec Moskvin 2022-05-03 22:55:38 UTC
That was quick, thanks!