The ejabberd ebuild installs a logrotate config for /var/log/jabber/*.log. However with the latest ebuild the log location is /var/log/ejabberd. But independent of that: ejabberd has its own logrotating mechanism, so I wonder if we should default-install a logrotate file to begin with. One can configure "log_rotate_size: infinity" if one wants to disable ejabberd's own logrotating mechanism, however that's non-obvious and if one has 2 rotating mechanisms obviously unexpected things happen. Maybe we want to install a commented out version of the logrotate.d file and have a comment in there mentioning this setting?
I am not sure if app-admin/logrotate provides a significant advantage over ejabberd's builtin logrotate (maybe compression?). If we decide to remove logrotate from ejabberd, then ideally we would be able to emit a deprecation warning to users still using deprecated stuff. However, I do not see how this is possible with logrotate as we can not hook into the part where logrotate is actually used (at least not easily). Hence, if we remove logrotate, then the best we could do is to have the ebuild emit a message explaining that the functionality was removed. Maybe a middle ground would be to install a logrotate example configuration in ejabberd's doc dir? Altough I believe that this would be unorthodox. But I also have no problem with keeping the logrotate conf and simply fix path in it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8d1e4560d3eff6e034ef1ef2e83ef37f4702510 commit c8d1e4560d3eff6e034ef1ef2e83ef37f4702510 Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2022-05-17 18:46:36 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2022-05-17 20:01:27 +0000 net-im/ejabberd: add 22.05 Fix bashism in OpenRC init script. Drop support for logrotate in favor of ejabberd's built-in log rotation mechanism. Also depend on >=acct-user/ejabberd-1, which will create the ejabberd with HOME set to /var/lib/ejabberd, i.e., ejabberd's spool directory. This allows us to drop ${PN}-19.08-ejabberdctl.patch. Closes: https://bugs.gentoo.org/841976 Closes: https://github.com/gentoo/gentoo/pull/25540 Signed-off-by: Florian Schmaus <flow@gentoo.org> net-im/ejabberd/Manifest | 2 + net-im/ejabberd/ejabberd-22.05.ebuild | 232 +++++++++++++++++++++++++++++ net-im/ejabberd/files/ejabberd-22.05.initd | 54 +++++++ 3 files changed, 288 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd1911fdc84b38dfd4136b8986b49940bc34c946 commit bd1911fdc84b38dfd4136b8986b49940bc34c946 Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2022-05-18 07:03:41 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2022-05-18 07:05:59 +0000 net-im/ejabberd: bring back logrotate Bug: https://bugs.gentoo.org/841976 Signed-off-by: Florian Schmaus <flow@gentoo.org> .../{ejabberd-22.05.ebuild => ejabberd-22.05-r1.ebuild} | 3 +++ net-im/ejabberd/files/ejabberd-22.05.logrotate | 13 +++++++++++++ 2 files changed, 16 insertions(+)
