Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 841836 - sys-apps/fwupd-1.8.0: refresh fails with "no libcurl support"
Summary: sys-apps/fwupd-1.8.0: refresh fails with "no libcurl support"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-04-30 10:44 UTC by Ferenc Erki
Modified: 2022-05-02 01:52 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ferenc Erki 2022-04-30 10:44:02 UTC
When using sys-apps/fwupd-1.8.0 to refresh firmware metadata, it fails with "no libcurl support":

$ sudo fwupdmgr refresh --force
Updating lvfs
no libcurl support

I believe this is caused by "-Dcurl="disabled" in the local emesonargs in src_configure.

I'll try to build with that enabled, and also send a GitHub PR if works.

Reproducible: Always
Comment 1 Patrick Holthaus 2022-05-01 11:14:23 UTC
Thanks, Ferenc,

Builds for me and fixes the problem. I would think that a "net-misc/curl" requirement in COMMON_DEPEND is necessary, though.
Comment 2 Ferenc Erki 2022-05-01 11:29:29 UTC
(In reply to Patrick Holthaus from comment #1)

> Builds for me and fixes the problem.

Thanks for the testing and feedback!

> I would think that a "net-misc/curl" requirement in COMMON_DEPEND is necessary, though.

Yes, that sounds correct. In previous sys-apps/fwupd ebuild versions, net-misc/curl was already in COMMON_DEPEND, together with -Dcurl="true" in emesonargs.

However in =sys-apps/fwupd-1.8.0, COMMON_DEPEND still included net-misc/curl, but emesonargs had -Dcurl="disabled" instead.

Therefore I believe emesonargs is the only bit to patch in the ebuild, apart from bumping the revision (which is required to trigger recompilation for those who already installed it without curl support).
Comment 3 Larry the Git Cow gentoo-dev 2022-05-02 01:52:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73cb61811d43977d178e9b1c0798d5398830ecf0

commit 73cb61811d43977d178e9b1c0798d5398830ecf0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-02 01:48:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-02 01:48:01 +0000

    sys-apps/fwupd: [QA] fix curl option
    
    curl isn't gone, but most options have been changed to
    tristate [0]. With =disabled, naturally, curl functionality
    is off and fwupd can't fetch from the internet at all, so
    updates are broken.
    
    Looks like this was a mistake given curl remains in RDEPEND
    too, and given the above.
    
    [0] https://github.com/fwupd/fwupd/commit/661990ed98870f8451015617701c50f68dc63824
    Closes: https://bugs.gentoo.org/841836
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/fwupd/{fwupd-1.8.0.ebuild => fwupd-1.8.0-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)