Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 840281 - media-gfx/shotwell-0.30.15 error: ‘EXPORT_DIALOG_DEFAULT_SCALE’ undeclared here (not in a function); did you mean ‘EXPORT_DIALOG_GET_CLASS’?
Summary: media-gfx/shotwell-0.30.15 error: ‘EXPORT_DIALOG_DEFAULT_SCALE’ undeclared he...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC64 Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-23 08:06 UTC by darkbasic
Modified: 2022-06-07 10:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,385.24 KB, text/plain)
2022-04-23 08:07 UTC, darkbasic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description darkbasic 2022-04-23 08:06:38 UTC
[318/360] powerpc64le-unknown-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.15/src -I../shotwell-0.30.15/vapi -Isrc/plugins -I../shotwell-0.30.15/src/plugins -I. -I../shotwell-0.30.15 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -pipe -mcpu=power9 -mtune=power9 -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c
FAILED: src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o 
powerpc64le-unknown-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.15/src -I../shotwell-0.30.15/vapi -Isrc/plugins -I../shotwell-0.30.15/src/plugins -I. -I../shotwell-0.30.15 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -pipe -mcpu=power9 -mtune=power9 -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c
src/shotwell.p/dialogs/ExportDialog.c:146:43: error: ‘EXPORT_DIALOG_DEFAULT_SCALE’ undeclared here (not in a function); did you mean ‘EXPORT_DIALOG_GET_CLASS’?
  146 | static gint export_dialog_current_scale = EXPORT_DIALOG_DEFAULT_SCALE;
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           EXPORT_DIALOG_GET_CLASS

Reproducible: Always




Portage 3.0.30 (python 3.9.11-final-0, default/linux/ppc64le/17.0/desktop/gnome/systemd, gcc-11.2.0, glibc-2.34-r10, 5.15.32-gentoo-dist ppc64le)
=================================================================
System uname: Linux-5.15.32-gentoo-dist-ppc64le-POWER9,_altivec_supported-with-glibc2.34
KiB Mem:    65536256 total,  26527500 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Sat, 23 Apr 2022 07:00:01 +0000
Head commit of repository gentoo: b380a3270132bb9f67b64453d674a83d9ccc7e0b
sh bash 5.1_p16
ld GNU ld (Gentoo 2.37_p1 p2) 2.37
app-misc/pax-utils:        1.3.3::gentoo
app-shells/bash:           5.1_p16::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.34.0-r9::gentoo
dev-lang/python:           3.9.11::gentoo, 3.10.3::gentoo
dev-lang/rust:             1.59.0::gentoo
dev-util/cmake:            3.22.2::gentoo
dev-util/meson:            0.60.3::gentoo
sys-apps/baselayout:       2.7-r3::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          250.4-r1::gentoo
sys-devel/autoconf:        2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.37_p1-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           13.0.1::gentoo
sys-devel/gcc:             11.2.0::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.6-r6::gentoo
sys-devel/lld:             13.0.1::gentoo
sys-devel/llvm:            13.0.1::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.34-r10::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24

darkbasic
    location: /var/db/repos/darkbasic
    masters: gentoo

pf4public
    location: /var/db/repos/pf4public
    masters: gentoo

ACCEPT_KEYWORDS="ppc64"
ACCEPT_LICENSE="@FREE @FREE unRAR"
CBUILD="powerpc64le-unknown-linux-gnu"
CFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
CHOST="powerpc64le-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -mcpu=power9 -mtune=power9"
GENTOO_MIRRORS="https://gentoo.mirror.garr.it/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j32"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aac acl alsa bluetooth branding bzip2 cairo cdda cdr cli colord crypt cups dbus dri dts dvd dvdr eds encode evo exif flac fortran gdbm gif gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk gui iconv icu introspection ipv6 jpeg lcms libglvnd libnotify libsecret mad mng mp3 mp4 mpeg nautilus ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppc64 ppds pulseaudio qt5 readline screencast sdl seccomp spell split-usr ssl startup-notification svg systemd tiff tracker truetype udev udisks unicode upower usb vaapi vorbis vpx vulkan wayland wxwidgets x264 xattr xcb xml xv xvid zeroconf zlib" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_PPC="altivec vsx vsx2 vsx3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" QEMU_SOFTMMU_TARGETS="ppc ppc64 i386 x86_64" QEMU_USER_TARGETS="ppc ppc64 i386 x86_64" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 darkbasic 2022-04-23 08:07:34 UTC
Created attachment 773450 [details]
build.log
Comment 2 darkbasic 2022-05-19 09:32:22 UTC
It's the same with 0.30.16:

[334/392] powerpc64le-unknown-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.16/src -I../shotwell-0.30.16/vapi -Isrc/plugins -I../shotwell-0.30.16/src/plugins -I. -I../shotwell-0.30.16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -pipe -mcpu=power9 -mtune=power9 -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c
FAILED: src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o 
powerpc64le-unknown-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.16/src -I../shotwell-0.30.16/vapi -Isrc/plugins -I../shotwell-0.30.16/src/plugins -I. -I../shotwell-0.30.16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -pipe -mcpu=power9 -mtune=power9 -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c
src/shotwell.p/dialogs/ExportDialog.c:146:43: error: ‘EXPORT_DIALOG_DEFAULT_SCALE’ undeclared here (not in a function); did you mean ‘EXPORT_DIALOG_GET_CLASS’?
  146 | static gint export_dialog_current_scale = EXPORT_DIALOG_DEFAULT_SCALE;
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           EXPORT_DIALOG_GET_CLASS
Comment 3 darkbasic 2022-05-19 09:49:56 UTC
I think this is a packaging issue because I've tried to reuse the 0.30.14 ebuild and bump it to .15/.16 and it compiles flawlessly.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-04 03:52:54 UTC
(In reply to darkbasic from comment #3)
> I think this is a packaging issue because I've tried to reuse the 0.30.14
> ebuild and bump it to .15/.16 and it compiles flawlessly.

Could you try to narrow down which option causes it then? The ebuilds only differ in a patch which got dropped that should be unrelated to this...
Comment 5 Florian Schmaus gentoo-dev 2022-06-07 09:16:12 UTC
The transpilled Vala to C code uses EXPORT_DIALOG_DEFAULT_SCALE (ExportDialog.c:146) before it is defined in ExportDialog.c:150. I wonder if this is a Vala transpiller bug. In fact, the dropped patch ("0.30.14-vala-0.52.8-compat.patch") was addressing this very issue:

--    private static int current_scale = DEFAULT_SCALE;
-+    private static int current_scale = 1200; //FIXME not needed with vala 0.54+

I am not an Vala expert, but if the patch comment is right, then maybe it is a simple matter of the ebuilding missing to declare

VALA_MIN_API_VERSION="0.54"
Comment 6 Florian Schmaus gentoo-dev 2022-06-07 10:00:25 UTC
Indeed, adding

VALA_MIN_API_VERSION="0.54"

to the ebuild fixes the issue for me.
Comment 7 Larry the Git Cow gentoo-dev 2022-06-07 10:06:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=314354a690c683b5a3b1b1ca2f1fcfe0be68f6ed

commit 314354a690c683b5a3b1b1ca2f1fcfe0be68f6ed
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2022-06-07 10:03:05 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-06-07 10:06:44 +0000

    media-gfx/shotwell: Set VALA_MIN_API_VERSION=0.54
    
    The ebuild for shotwell 0.13.14 contained a patch
    0.30.14-vala-0.52.8-compat.patch that made shotwell compile on Vala <
    0.54. However this patch was removed with
    532f5153c752 ("media-gfx/shotwell: Drop old versions") and not carried
    over to newer shotwell ebuilds. However, those current ebuilds failed to
    declare a minimum dependency on Vala 0.54, causing bug #840281. This
    commit addresses the bug by adding VALA_MIN_API_VERSION=0.54 to the
    ebuild.
    
    Closes: https://bugs.gentoo.org/840281
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 media-gfx/shotwell/shotwell-0.30.15.ebuild | 1 +
 media-gfx/shotwell/shotwell-0.30.16.ebuild | 1 +
 2 files changed, 2 insertions(+)