Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839900 - app-shells/zsh-5.8.1-r1 is taking more than a minute for startup on slow filesystem
Summary: app-shells/zsh-5.8.1-r1 is taking more than a minute for startup on slow file...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-21 13:42 UTC by Klaus Ethgen
Modified: 2022-05-02 08:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch that fix the problem (0001-Revert-49792-Non-interative-shell-input-is-line-buff.patch,2.27 KB, patch)
2022-04-22 07:48 UTC, Klaus Ethgen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Klaus Ethgen 2022-04-21 13:42:00 UTC
After the patch in 5.8.1-r1, a startup of zsh takes much more than one minute reading .zshenv and .zshrc from a slow filesystem (9p) inside of a virtual machine.

Reading the files with less or cat is reasonable fast (around 0.01 seconds). Debuging with strace shows that it is taking all the time with reading the file(s) char by char.

Reproducible: Always

Steps to Reproduce:
1. Install zsh-5.8.1-r1
2. Run it on slower filesystem
Actual Results:  
Slow start as hell

Expected Results:  
Normal, fast start
Comment 1 Klaus Ethgen 2022-04-22 07:48:09 UTC
Created attachment 772826 [details, diff]
Patch that fix the problem

By the way, I added this patch as user patch and the problem is solved.

It is just the reverting of the added patch.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-23 01:57:45 UTC
(In reply to Klaus Ethgen from comment #1)
> Created attachment 772826 [details, diff] [details, diff]
> Patch that fix the problem
> 
> By the way, I added this patch as user patch and the problem is solved.
> 
> It is just the reverting of the added patch.

Please report the issue upstream & link it here?
Comment 3 Klaus Ethgen 2022-04-23 07:13:38 UTC
I don't understand.

The patch is a gentoo only patch. Upstream works pretty well.
Comment 4 Jordan Patterson 2022-04-25 18:49:01 UTC
The patch was applied from upstream zsh, it just hasn't been in a release version yet.  I sent a bug report to their mailing list here: https://www.zsh.org/mla/workers/2022/msg00420.html
Comment 5 Larry the Git Cow gentoo-dev 2022-05-02 08:41:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6d64f8fa58bae8d750bade521d5354507c9c483

commit d6d64f8fa58bae8d750bade521d5354507c9c483
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2022-05-02 08:36:59 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2022-05-02 08:41:43 +0000

    app-shells/zsh: Revbump to fix performance regression
    
    which was introduced with previous regression fix.
    
    Closes: https://bugs.gentoo.org/839900
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../zsh-5.8.1-performance_regression_fix.patch     | 139 +++++++++++++++++++++
 .../{zsh-5.8.1-r1.ebuild => zsh-5.8.1-r2.ebuild}   |   1 +
 2 files changed, 140 insertions(+)