Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839531 - net-p2p/qbittorrent-4.4.2: webui useflag does not work without disabling gui useflag.
Summary: net-p2p/qbittorrent-4.4.2: webui useflag does not work without disabling gui ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal minor (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-19 15:35 UTC by Maria Keating
Modified: 2022-10-04 19:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maria Keating 2022-04-19 15:35:53 UTC
The qbittorrent-nox binary is not compiled unless the gui useflag is disabled. The systemd service files are still installed but are, predictably, useless.

Reproducible: Always

Steps to Reproduce:
1. emerge with +gui +webui
2. check for the qbittorrent-nox binary (does not exist)
3. emerge with -gui +webui
4. check for the qbittorrent-nox binary (does exist)
Actual Results:  
The qbittorrent-nox binary was not installed without disabling the gui useflag.

Expected Results:  
The qbittorent-nox binary is installed without disabling the gui useflag.

If this is a limitation of the project itself, I imagine enabling the webui useflag should require disabling the gui useflag.
Comment 1 Larry the Git Cow gentoo-dev 2022-04-19 16:39:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=248ae6b91f5534ba75c5b5d9485c73f617dabccb

commit 248ae6b91f5534ba75c5b5d9485c73f617dabccb
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-19 16:33:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-19 16:39:09 +0000

    net-p2p/qbittorrent: use multibuild for webui (unkeyworded)
    
    Otherwise, with USE=gui, qbittorent-nox doesn't get built.
    
    Unkeyworded for testing.
    
    Closes: https://bugs.gentoo.org/839531
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/qbittorrent/qbittorrent-4.4.2-r1.ebuild | 98 +++++++++++++++++++++++++
 1 file changed, 98 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2022-04-19 20:52:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0f1d8f865009ffbd7e822f7deefc022e911aab5e

commit 0f1d8f865009ffbd7e822f7deefc022e911aab5e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-19 20:51:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-19 20:52:00 +0000

    net-p2p/qbittorrent: refine webui/gui logic
    
    Closes: https://bugs.gentoo.org/839531
    Thanks-to: maria
    Signed-off-by: Sam James <sam@gentoo.org>

 ...-4.4.2-r1.ebuild => qbittorrent-4.4.2-r2.ebuild} | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2022-04-19 21:00:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b210128f77b6f925b812f91a83095d20fe811211

commit b210128f77b6f925b812f91a83095d20fe811211
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-19 21:00:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-19 21:00:29 +0000

    net-p2p/qbittorrent: keyword 4.4.2-r2
    
    Closes: https://bugs.gentoo.org/839531
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/qbittorrent/qbittorrent-4.4.2-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-08-10 04:28:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=964d233a12d97d0ea591e3c8c583c6a6b8129405

commit 964d233a12d97d0ea591e3c8c583c6a6b8129405
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-08-10 04:23:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-10 04:26:14 +0000

    net-p2p/qbittorrent: build GUI component too for webui multibuild
    
    This allows the webui settings to show up in the GUI.
    
    Bug: https://bugs.gentoo.org/839531
    Closes: https://bugs.gentoo.org/864731
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/qbittorrent/qbittorrent-4.4.3.1-r1.ebuild | 109 ++++++++++++++++++++++
 net-p2p/qbittorrent/qbittorrent-9999.ebuild       |   2 +-
 2 files changed, 110 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2022-10-04 19:14:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1131bf8afdd369ad559dd311af06522c260fd9f

commit d1131bf8afdd369ad559dd311af06522c260fd9f
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-10-04 19:12:10 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-10-04 19:12:10 +0000

    net-p2p/qbittorrent: rework multibuild logic
    
    We want to control the GUI option with multibuild, not WEBUI.
    
    Bug: https://bugs.gentoo.org/839531
    Bug: https://bugs.gentoo.org/864731
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 ...nt-4.4.5.ebuild => qbittorrent-4.4.5-r1.ebuild} | 22 +++++++++-------------
 net-p2p/qbittorrent/qbittorrent-9999.ebuild        | 22 +++++++++-------------
 2 files changed, 18 insertions(+), 26 deletions(-)