Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839222 - media-libs/opus: automated shellcheck found errors
Summary: media-libs/opus: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-04-23 01:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:06 UTC
Shellckeck found errors in one or more shellscripts provided by media-libs/opus.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/media-libs/opus/opus-1.3.1-r2.ebuild:40

	for i in "${INTRINSIC_FLAGS}" ; do
                 ^^^^^^^^^^^^^^^^^^^^
error: Since you double quoted this, it will not word split, and the loop will only run once. (https://github.com/koalaman/shellcheck/wiki/SC2066)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-04-23 01:21:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b81fb8d368376faefc0d71a15c44d1cfd9d8dab1

commit b81fb8d368376faefc0d71a15c44d1cfd9d8dab1
Author:     Dustin Smith <smith.dustin2017@gmail.com>
AuthorDate: 2022-04-22 02:22:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-23 01:20:05 +0000

    media-libs/opus: fix word split issue in ebuild
    
    shellbugbot points out an issue with shellcheck where $INTRINSIC_FLAGS
    won't be split on space because of the double quoting.  If I am reading
    the ebuild correctly, then "use" is receiving one big argument
    "cpu_flags_x86_sse cpu_flags_arm_neon" in just one iteration.
    
    This commit just removes the double quotes to fix this.
    
    Bug: https://bugs.gentoo.org/839222
    Closes: https://github.com/gentoo/gentoo/pull/25147
    Signed-off-by: Dustin Smith <smith.dustin2017@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/opus/{opus-1.3.1-r2.ebuild => opus-1.3.1-r3.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)