Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839219 - dev-tcltk/blt: automated shellcheck found errors
Summary: dev-tcltk/blt: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: TCL/TK Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-06-27 06:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:06 UTC
Shellckeck found errors in one or more shellscripts provided by dev-tcltk/blt.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/dev-tcltk/blt/blt-2.5.3-r1.ebuild:125

	for f in `ls "${ED}"/usr/share/man/mann` ; do
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: Iterating over ls output is fragile. Use globs. (https://github.com/koalaman/shellcheck/wiki/SC2045)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-06-27 06:40:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d4a9dd58efa5da36c7bd6a6f655dda799ca0115

commit 8d4a9dd58efa5da36c7bd6a6f655dda799ca0115
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2022-06-27 06:40:24 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2022-06-27 06:40:24 +0000

    dev-tcltk/blt: fix globs expansion
    
    Closes: https://bugs.gentoo.org/839219
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 dev-tcltk/blt/blt-2.5.3-r1.ebuild | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)