Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839216 - net-firewall/ufw: automated shellcheck found errors
Summary: net-firewall/ufw: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-07-24 16:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:05 UTC
Shellckeck found errors in one or more shellscripts provided by net-firewall/ufw.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/net-firewall/ufw/ufw-0.36-r1.ebuild:201

		for rv in "${REPLACING_VERSIONS}"; do
                          ^^^^^^^^^^^^^^^^^^^^^^^
error: Since you double quoted this, it will not word split, and the loop will only run once. (https://github.com/koalaman/shellcheck/wiki/SC2066)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-07-24 16:49:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2274610a3adacc42b560ab36fae5498389c6790e

commit 2274610a3adacc42b560ab36fae5498389c6790e
Author:     Dustin Smith <smith.dustin2017@gmail.com>
AuthorDate: 2022-07-24 01:52:36 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-07-24 16:49:19 +0000

    net-firewall/ufw: fix word split issue
    
    Shellcheck found another SC2066 bug -- this is just a quick commit to
    fix it and make the for loop work as intended.
    
    Bug: https://bugs.gentoo.org/839216
    Signed-off-by: Dustin Smith <smith.dustin2017@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/26560
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 net-firewall/ufw/ufw-0.36-r1.ebuild | 2 +-
 net-firewall/ufw/ufw-0.36.1.ebuild  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)