Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839207 - app-portage/elogv: automated shellcheck found errors
Summary: app-portage/elogv: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sebastian Pipping
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-04-30 18:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:04 UTC
Shellckeck found errors in one or more shellscripts provided by app-portage/elogv.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/app-portage/elogv/elogv-0.7.8-r3.ebuild:32

		for i in $(ls "${ED}"/usr/share/locale/) ; do
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: Iterating over ls output is fragile. Use globs. (https://github.com/koalaman/shellcheck/wiki/SC2045)

------------------------------------------------
script: /usr/portage/app-portage/elogv/elogv-0.7.9.ebuild:32

		for i in $(ls "${ED}"/usr/share/locale/) ; do
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: Iterating over ls output is fragile. Use globs. (https://github.com/koalaman/shellcheck/wiki/SC2045)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-04-30 18:08:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b08bf08f317dc8202752b259c73f32fbfc781cd9

commit b08bf08f317dc8202752b259c73f32fbfc781cd9
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2022-04-30 18:05:03 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2022-04-30 18:07:27 +0000

    app-portage/elogv: Improve LINGUAS cleanup code
    
    Closes: https://bugs.gentoo.org/839207
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-3.0.30, Repoman-3.0.3

 app-portage/elogv/elogv-0.7.9-r1.ebuild | 56 +++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)