Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839195 - sys-kernel/genkernel: automated shellcheck found errors
Summary: sys-kernel/genkernel: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on: 861110
Blocks:
  Show dependency tree
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-07-26 04:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:03 UTC
Shellckeck found errors in one or more shellscripts provided by sys-kernel/genkernel.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/sys-kernel/genkernel/genkernel-4.2.6-r2.ebuild:296

	if [[ ${n_root_args} > 1 ]] ; then
                             ^
error: > is for string comparisons. Use -gt instead. (https://github.com/koalaman/shellcheck/wiki/SC2071)

------------------------------------------------
script: /usr/portage/sys-kernel/genkernel/genkernel-4.2.5.ebuild:290

	if [[ ${n_root_args} > 1 ]] ; then
                             ^
error: > is for string comparisons. Use -gt instead. (https://github.com/koalaman/shellcheck/wiki/SC2071)

------------------------------------------------
script: /usr/portage/sys-kernel/genkernel/genkernel-9999.ebuild:291

	if [[ ${n_root_args} > 1 ]] ; then
                             ^
error: > is for string comparisons. Use -gt instead. (https://github.com/koalaman/shellcheck/wiki/SC2071)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-04-19 23:17:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=39935b585f184238be648a193fb8a68f479196b1

commit 39935b585f184238be648a193fb8a68f479196b1
Author:     Robin H. Johnson <robbat2@gentoo.org>
AuthorDate: 2022-04-19 23:16:45 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2022-04-19 23:17:01 +0000

    sys-kernel/genkernel: fix shellcheck error
    
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
    Fixes: https://bugs.gentoo.org/839195

 sys-kernel/genkernel/genkernel-4.2.5.ebuild    | 2 +-
 sys-kernel/genkernel/genkernel-4.2.6-r2.ebuild | 2 +-
 sys-kernel/genkernel/genkernel-9999.ebuild     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)