Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839189 - eclass/tests/qmail.sh: automated shellcheck found errors
Summary: eclass/tests/qmail.sh: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rolf Eike Beer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-04-19 21:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:02 UTC
Shellckeck found errors in one or more shellscripts provided by eclass/tests.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/eclass/tests/qmail.sh:16

			return tend 1 "${i} badly accepted"
                               ^^^^
error: Only one integer 0-255 can be returned. Use stdout for other data. (https://github.com/koalaman/shellcheck/wiki/SC2151)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-04-19 21:32:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74780679b37fc00aa39804d8cc3a90abf6e2c745

commit 74780679b37fc00aa39804d8cc3a90abf6e2c745
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-04-19 21:31:52 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-04-19 21:31:52 +0000

    eclass/tests/qmail.sh: eend and return should be separate statements
    
    Closes: https://bugs.gentoo.org/839189
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 eclass/tests/qmail.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)