Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839174 - sys-apps/memtest86+: automated shellcheck found errors
Summary: sys-apps/memtest86+: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2023-05-19 12:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:01 UTC
Shellckeck found errors in one or more shellscripts provided by sys-apps/memtest86+.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/sys-apps/memtest86+/files/39_memtest86+-r1:30

	if [ -n "{submenu_indentation}" ]; then
                 ^^^^^^^^^^^^^^^^^^^^^
error: Argument to -n is always true due to literal strings. (https://github.com/koalaman/shellcheck/wiki/SC2157)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2023-05-19 12:59:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1cb153f2fddd44769e159e0fd0a24298f88d36ab

commit 1cb153f2fddd44769e159e0fd0a24298f88d36ab
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2023-05-19 12:57:07 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2023-05-19 12:59:36 +0000

    sys-apps/memtest86+: fix syntax error in grub.d file
    
    This minor syntax error would cause some indentation inconsistency
    
    Closes: https://bugs.gentoo.org/839174
    
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 sys-apps/memtest86+/files/39_memtest86+-r2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)