Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839168 - sys-apps/memtest86: automated shellcheck found errors
Summary: sys-apps/memtest86: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2023-08-15 02:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:00 UTC
Shellckeck found errors in one or more shellscripts provided by sys-apps/memtest86.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/sys-apps/memtest86/files/39_memtest86-r1:30

	if [ -n "{submenu_indentation}" ]; then
                 ^^^^^^^^^^^^^^^^^^^^^
error: Argument to -n is always true due to literal strings. (https://github.com/koalaman/shellcheck/wiki/SC2157)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2023-08-15 02:23:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6686427c5cb7178fe0db7c4ad743a02b262a844a

commit 6686427c5cb7178fe0db7c4ad743a02b262a844a
Author:     Dustin Smith <d.usty360@gmail.com>
AuthorDate: 2023-08-15 01:32:48 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-08-15 02:22:02 +0000

    sys-apps/memtest86: fix missing dollar sign in shell variable
    
    Per shellcheckbot, the shell script 39_memtest86-r1 is using the literal
    string {submenu_indentation} rather than the variable
    $submenu_indentation. This commit fixes that.
    
    Closes: https://bugs.gentoo.org/839168
    Signed-off-by: Dustin Smith <d.usty360@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/32314
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-apps/memtest86/files/39_memtest86-r1                                | 2 +-
 .../memtest86/{memtest86-4.3.7-r2.ebuild => memtest86-4.3.7-r3.ebuild}  | 0
 2 files changed, 1 insertion(+), 1 deletion(-)