Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839165 - dev-python/setuptools: automated shellcheck found errors
Summary: dev-python/setuptools: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-04-20 07:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:00 UTC
Shellckeck found errors in one or more shellscripts provided by dev-python/setuptools.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/dev-python/setuptools/setuptools-60.9.2.ebuild:91

	has "${EPYTHON}" python3.{8..10} pypy3 || continue
                                                  ^^^^^^^^
error: In functions, use return instead of continue. (https://github.com/koalaman/shellcheck/wiki/SC2104)

------------------------------------------------
script: /usr/portage/dev-python/setuptools/setuptools-62.1.0.ebuild:102

	has "${EPYTHON}" python3.{8..10} pypy3 || continue
                                                  ^^^^^^^^
error: In functions, use return instead of continue. (https://github.com/koalaman/shellcheck/wiki/SC2104)

------------------------------------------------
script: /usr/portage/dev-python/setuptools/setuptools-61.3.1-r1.ebuild:102

	has "${EPYTHON}" python3.{8..10} pypy3 || continue
                                                  ^^^^^^^^
error: In functions, use return instead of continue. (https://github.com/koalaman/shellcheck/wiki/SC2104)

------------------------------------------------
script: /usr/portage/dev-python/setuptools/setuptools-60.10.0.ebuild:92

	has "${EPYTHON}" python3.{8..10} pypy3 || continue
                                                  ^^^^^^^^
error: In functions, use return instead of continue. (https://github.com/koalaman/shellcheck/wiki/SC2104)

------------------------------------------------
script: /usr/portage/dev-python/setuptools/setuptools-60.5.0.ebuild:69

	has "${EPYTHON}" python3.{8..10} pypy3 || continue
                                                  ^^^^^^^^
error: In functions, use return instead of continue. (https://github.com/koalaman/shellcheck/wiki/SC2104)

------------------------------------------------
script: /usr/portage/dev-python/setuptools/setuptools-61.3.0.ebuild:103

	has "${EPYTHON}" python3.{8..10} pypy3 || continue
                                                  ^^^^^^^^
error: In functions, use return instead of continue. (https://github.com/koalaman/shellcheck/wiki/SC2104)

------------------------------------------------
script: /usr/portage/dev-python/setuptools/setuptools-62.0.0.ebuild:102

	has "${EPYTHON}" python3.{8..10} pypy3 || continue
                                                  ^^^^^^^^
error: In functions, use return instead of continue. (https://github.com/koalaman/shellcheck/wiki/SC2104)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-04-20 07:47:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=78cc9078a2e30e9d46d26980e8d58eed9d4d2378

commit 78cc9078a2e30e9d46d26980e8d58eed9d4d2378
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-04-20 06:57:05 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-04-20 07:47:06 +0000

    dev-python/setuptools: Use `return` instead of `continue`
    
    Closes: https://bugs.gentoo.org/839165
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/setuptools/setuptools-60.10.0.ebuild   | 2 +-
 dev-python/setuptools/setuptools-60.5.0.ebuild    | 2 +-
 dev-python/setuptools/setuptools-60.9.2.ebuild    | 2 +-
 dev-python/setuptools/setuptools-61.3.0.ebuild    | 2 +-
 dev-python/setuptools/setuptools-61.3.1-r1.ebuild | 2 +-
 dev-python/setuptools/setuptools-62.0.0.ebuild    | 2 +-
 dev-python/setuptools/setuptools-62.1.0.ebuild    | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)