Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839156 - sys-devel/binutils-apple: automated shellcheck found errors
Summary: sys-devel/binutils-apple: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
: 839159 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-04-18 10:52 UTC by shellbugbot
Modified: 2022-04-20 06:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 10:52:13 UTC
Shellckeck found errors in one or more shellscripts provided by sys-devel/binutils-apple.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/sys-devel/binutils-apple/binutils-apple-8.2.1-r1.ebuild:338

	if ! [ "${EPREFIX}"/usr/bin/clang ] ; then
                           ^^^^^^^^^^^^^^
error: Argument to implicit -n is always true due to literal strings. (https://github.com/koalaman/shellcheck/wiki/SC2157)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 shellbugbot 2022-04-18 11:02:17 UTC
*** Bug 839159 has been marked as a duplicate of this bug. ***
Comment 2 Larry the Git Cow gentoo-dev 2022-04-20 06:15:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e2f7063a89cd6ad368706c9a433ce7833aa5b21

commit 4e2f7063a89cd6ad368706c9a433ce7833aa5b21
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2022-04-20 06:13:50 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2022-04-20 06:15:41 +0000

    sys-devel/binutils-apple-8.2.1-r1: fix clang check #839156
    
    shellcheck pointed out that checking a non-empty string constant to be
    non-empty always evaluates to true
    
    Closes: https://bugs.gentoo.org/839156
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 sys-devel/binutils-apple/binutils-apple-8.2.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)