Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839105 - net-firewall/xtables-addons-3.18: error: implicit declaration of function ‘PDE_DATA’
Summary: net-firewall/xtables-addons-3.18: error: implicit declaration of function ‘PD...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 08:32 UTC by Attila Tóth
Modified: 2022-04-18 18:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Tóth 2022-04-18 08:32:36 UTC
After upgrading kernel (and kernel-headers) to 5.17.* (currently sys-kernel/gentoo-sources-5.17.3), net-firewall/xtables-addons-3.18 no longer compiles.

  x86_64-pc-linux-gnu-gcc -Wp,-MMD,/var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/.xt_pknock.o.d -nostdinc -I./arch/x86/include -I./arch/x86/include/generated  -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/compiler-version.h -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h  -fplugin=./scripts/gcc-plugins/structleak_plugin.so -fplugin=./scripts/gcc-plugins/randomize_layout_plugin.so -fplugin=./scripts/gcc-plugins/constify_plugin/constify_plugin.so -fplugin=./scripts/gcc-plugins/stackleak_plugin.so -fplugin=./scripts/gcc-plugins/utilities_plugin/utilities_plugin.so -fplugin=./scripts/gcc-plugins/size_overflow_plugin/size_overflow_plugin.so -fplugin=./scripts/gcc-plugins/initify_plugin.so -fplugin=./scripts/gcc-plugins/rap_plugin/rap_plugin.so -fplugin=./scripts/gcc-plugins/respectre_plugin/respectre_plugin.so -fplugin=./scripts/gcc-plugins/autoslab_plugin/autoslab_plugin.so -fplugin-arg-structleak_plugin-byref-all -fplugin-arg-randomize_layout_plugin-performance-mode -fplugin-arg-stackleak_plugin-track-lowest-sp=120 -fplugin-arg-utilities_plugin-align-init-text-bits=4 -fplugin-arg-utilities_plugin-convert-nolocals -fplugin-arg-size_overflow_plugin-check-fns -fplugin-arg-initify_plugin-search_init_exit_functions -fplugin-arg-rap_plugin-include -fplugin-arg-rap_plugin-typecheck=call -fplugin-arg-rap_plugin-typecheck=ret -fplugin-arg-rap_plugin-xor -fplugin-arg-rap_plugin-hash=abs-finish -fplugin-arg-rap_plugin-hash=abs-ops -fplugin-arg-rap_plugin-hash=abs-attr '-fplugin-arg-rap_plugin-retabort=rap_ret_abort %k0' -fplugin-arg-rap_plugin-sls -fplugin-arg-rap_plugin-typecheck=nospec -fplugin-arg-rap_plugin-kernexec_method=bts -fplugin-arg-respectre_plugin-loopindex -fplugin-arg-respectre_plugin-ssb -DSTRUCTLEAK_PLUGIN -DRANDSTRUCT_PLUGIN -DCONSTIFY_PLUGIN -DSTACKLEAK_PLUGIN -DUTILITIES_PLUGIN -DSIZE_OVERFLOW_PLUGIN -DINITIFY_PLUGIN -DRAP_PLUGIN_HASH -DRETPOLINE_PLUGIN -DKERNEXEC_PLUGIN -DRESPECTRE_PLUGIN -DRESPECTRE_PLUGIN_SSB -DAUTOSLAB_PLUGIN   -include include/generated/ksyms.h -fplugin-arg-utilities_plugin-asm_include=./arch/x86/include/generated/asm/asmmacro.s -D__KERNEL__ -fmacro-prefix-map=./= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu89 -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -mno-popcnt -fcf-protection=none -m64 -falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387 -mpreferred-stack-boundary=3 -mskip-rax-setup -march=haswell -mno-red-zone -mcmodel=kernel -Wno-sign-compare -fno-asynchronous-unwind-tables -mindirect-branch=keep -mindirect-branch-register -fno-jump-tables -Wa,-mx86-used-note=no -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=1024 -fno-stack-protector -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fomit-frame-pointer -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-zero-length-bounds -Wno-array-bounds -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wcast-function-type -Wno-packed-not-aligned -I/var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/..  -DMODULE  -DKBUILD_BASENAME='"xt_pknock"' -DKBUILD_EXTMOD='"/var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions"' -DKBUILD_MODNAME='"xt_pknock"' -D__KBUILD_MODNAME=kmod_xt_pknock -DAUTOSLAB_BASENAME='"pknock_xt_pknock"' -c -o /var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/xt_pknock.o /var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/xt_pknock.c  ; ./tools/objtool/objtool orc generate  --module  --no-fp   --retpoline  --uaccess   --sls   --rap  /var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/xt_pknock.o
/var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/xt_pknock.c: In function ‘pknock_proc_open’:
/var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/xt_pknock.c:280:31: error: implicit declaration of function ‘PDE_DATA’; did you mean ‘NODE_DATA’? [-Werror=implicit-function-declaration]
  280 |                 sf->private = PDE_DATA(inode);
      |                               ^~~~~~~~
      |                               NODE_DATA
/var/tmp/portage/net-firewall/xtables-addons-3.18/work/xtables-addons-3.18/extensions/pknock/xt_pknock.c:280:29: warning: assignment to ‘void *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  280 |                 sf->private = PDE_DATA(inode);
      |                             ^


Reproducible: Always
Comment 1 Attila Tóth 2022-04-18 08:35:42 UTC
Solution: bump xtables-addons to version 3.20. Trivial action by simply renaming the ebuild is sufficient.
Comment 2 Larry the Git Cow gentoo-dev 2022-04-18 18:44:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fdbfec61d4e3f2dd4a3b167a863cf83830a8df39

commit fdbfec61d4e3f2dd4a3b167a863cf83830a8df39
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-18 18:44:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-18 18:44:29 +0000

    net-firewall/xtables-addons: add 3.20 (5.17+ compat)
    
    Closes: https://bugs.gentoo.org/839105
    Bug: https://bugs.gentoo.org/836595
    Bug: https://bugs.gentoo.org/832666
    Signed-off-by: Sam James <sam@gentoo.org>

 net-firewall/xtables-addons/Manifest               |   1 +
 .../xtables-addons/xtables-addons-3.20.ebuild      | 189 +++++++++++++++++++++
 2 files changed, 190 insertions(+)