Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839042 - dev-java/fop: binary files in git repository
Summary: dev-java/fop: binary files in git repository
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Florian Schmaus
URL: https://qa-reports.gentoo.org/output/...
Whiteboard:
Keywords: QAcanfix
Depends on: 836753
Blocks:
  Show dependency tree
 
Reported: 2022-04-17 19:05 UTC by Ulrich Müller
Modified: 2022-04-17 22:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2022-04-17 19:05:27 UTC
As reported (see URL):
dev-java/fop/files/fop-2.7-core-event-models.jar: application/zip; charset=binary (size=8835)
dev-java/fop/files/fop-2.7-test-event-model.jar: application/zip; charset=binary (size=428)

These files should be hosted as distfile(s), not in the gentoo repository.

Policy reference:
https://devmanual.gentoo.org/general-concepts/tree/index.html#what-belongs-in-the-tree
Comment 1 Volkmar W. Pogatzki 2022-04-17 19:24:05 UTC
(In reply to Ulrich Müller from comment #0)
> As reported (see URL):
> dev-java/fop/files/fop-2.7-core-event-models.jar: application/zip;
> charset=binary (size=8835)
> dev-java/fop/files/fop-2.7-test-event-model.jar: application/zip;
> charset=binary (size=428)
> 
> These files should be hosted as distfile(s), not in the gentoo repository.
> 
> Policy reference:
> https://devmanual.gentoo.org/general-concepts/tree/index.html#what-belongs-
> in-the-tree

In an ideal world those files should not even exist (bug #836753).
Comment 2 Ulrich Müller gentoo-dev 2022-04-17 19:40:06 UTC
(In reply to Volkmar W. Pogatzki from comment #1)
> In an ideal world those files should not even exist (bug #836753).

I don't see any fix attached to that bug. Until then, these files should be hosted elsewhere, or commit 55f3ec5078e3d85b0cce92b424b9202dd6a9b580 should be reverted.
Comment 3 Larry the Git Cow gentoo-dev 2022-04-17 22:27:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a1a75d34f4cd056daa686de3d8ba643d8e5e3ed

commit 8a1a75d34f4cd056daa686de3d8ba643d8e5e3ed
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2022-04-17 22:24:40 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-04-17 22:27:07 +0000

    dev-java/fop: remove binaries out of files/
    
    Closes: https://bugs.gentoo.org/839042
    Fixes: 55f3ec5078e3 ("dev-java/fop: Bump to 2.7")
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 dev-java/fop/Manifest                            |   1 +
 dev-java/fop/files/fop-2.7-core-event-models.jar | Bin 8835 -> 0 bytes
 dev-java/fop/files/fop-2.7-test-event-model.jar  | Bin 428 -> 0 bytes
 dev-java/fop/fop-2.7.ebuild                      |   9 ++++++---
 4 files changed, 7 insertions(+), 3 deletions(-)