Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 838727 - gnome-extra/gnome-contacts-42.0 does not build with vala-52.10
Summary: gnome-extra/gnome-contacts-42.0 does not build with vala-52.10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-04-16 03:14 UTC by Jay Faulkner
Modified: 2022-04-17 00:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
jayf-838727-build-log.txt (jayf-838727-build-log.txt,19.27 KB, text/plain)
2022-04-16 20:32 UTC, Jay Faulkner
Details
jayf-838727-emerge-info.txt (jayf-838727-emerge-info.txt,7.10 KB, text/plain)
2022-04-16 20:33 UTC, Jay Faulkner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Faulkner 2022-04-16 03:14:24 UTC
gnome-extra/gnome-contacts-42.0 will happily attempt to build on a system with stable keyword vala (0.52.10), however, in my case it failed with this error: https://dpaste.com/7NDTHM425 (build.log).

When I installed the next newest version of vala; 0.54.7, it was used for the build and the build completed successfully.
Comment 1 Mike Gilbert gentoo-dev 2022-04-16 17:54:13 UTC
Please provide emerge --info and attach a full build log. Pastebin links tend to expire/fail over time.

Change the bug status back to UNCONFIRMED once the above has been provided.
Comment 2 Jay Faulkner 2022-04-16 20:32:45 UTC
Created attachment 771086 [details]
jayf-838727-build-log.txt
Comment 3 Jay Faulkner 2022-04-16 20:33:09 UTC
Created attachment 771089 [details]
jayf-838727-emerge-info.txt
Comment 4 Jay Faulkner 2022-04-16 20:43:37 UTC
I was able to fix this locally by adding 

VALA_MIN_API_VERSION="0.54"

to gnome-contacts-42.0.ebuild. I would create a patch but I suspect it'd be more pain to merge it in than it would be to add the line locally :).
Comment 5 Jay Faulkner 2022-04-16 21:02:51 UTC
It seems like: https://gitlab.gnome.org/GNOME/gnome-contacts/-/tree/0733806c026504db7f644abd2d04385f54161773 introduced the code that the earlier vala (seemingly) breaks. But meson.build in the gnome-contacts repo still only specifies a minimum of 0.40.10.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-16 21:21:45 UTC
(In reply to Jay Faulkner from comment #4)
> I was able to fix this locally by adding 
> 
> VALA_MIN_API_VERSION="0.54"
> 
> to gnome-contacts-42.0.ebuild. I would create a patch but I suspect it'd be
> more pain to merge it in than it would be to add the line locally :).

it isn't, it's very easy to merge :p
Comment 7 Jay Faulkner 2022-04-16 22:51:11 UTC
I was able to reproduce this on an otherwise up-to-date unstable system (that also had `vala:0.52` installed) by running VALA_MAX_API_VERSION="0.52" emerge -1 =gnome-extra/gnome-contacts-42.0.
Comment 8 Larry the Git Cow gentoo-dev 2022-04-17 00:44:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3acb14fad25898657881117d29966ef8c20a11c5

commit 3acb14fad25898657881117d29966ef8c20a11c5
Author:     Jay Faulkner <jay@jvf.cc>
AuthorDate: 2022-04-16 23:33:43 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-17 00:44:18 +0000

    gnome-extra/gnome-contacts: Require >=dev-lang/vala-0.54
    
    Despite the meson.build upstream stating a minimum vala API of 0.40,
    any builds with that API or any lower that 0.54 fail.
    
    Closes: https://bugs.gentoo.org/838727
    Closes: https://github.com/gentoo/gentoo/pull/25052
    Signed-off-by: Jay Faulkner <jay@jvf.cc>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 gnome-extra/gnome-contacts/gnome-contacts-42.0.ebuild | 1 +
 1 file changed, 1 insertion(+)