Bug 835471 added an unconditional dependency on app-editors/vim-core to media-libs/libvmaf in order to fix failing tests with USE="test". However, this dependency is unconditional and pulls in the whole vim for just a video quality assessment library, which is not acceptable. The media-libs/libvmaf ebuild contains the following comment: # The app-editors/vim-core dep is needed to embed models within the library # could be made into a useflag if someones express the need for it Therefore I request the app-editors/vim-core dependency to be made conditional on the "test" or some other USE flag.
FWIW vim-core isn't meant to be "the whole vim", it provides other tools like xxd.
(Also, the fix wasn't just for tests. But a flag could still be used in theory.)
(In reply to Sam James from comment #1) > FWIW vim-core isn't meant to be "the whole vim", it provides other tools > like xxd. It looks like the whole vim in practice: $ emerge -pv vim-core > These are the packages that would be merged, in order: > > Calculating dependencies... done! > [ebuild N ] app-eselect/eselect-vi-1.2::gentoo 3 KiB > [ebuild N ] app-editors/vim-core-8.2.4586::gentoo USE="acl nls -minimal" 15 873 KiB > [ebuild N ] app-editors/vim-8.2.4586::gentoo USE="X acl crypt gpm lua nls sound -cscope -debug -minimal -perl -python -racket -ruby (-selinux) -tcl -terminal -vim-pager" LUA_SINGLE_TARGET="lua5-1 -luajit" PYTHON_SINGLE_TARGET="python3_9 -python3_8 -python3_10" 0 KiB > [ebuild N ] app-vim/gentoo-syntax-1::gentoo USE="-ignore-glep31" 20 KiB > > Total: 4 packages (4 new), Size of downloads: 15 895 KiB > (Also, the fix wasn't just for tests. But a flag could still be used in theory.) Ack, but the upstream says the built-in models are optional so if they pull in significant dependencies they should at least be behind a USE flag.
I thought I at least fixed the test failure and made the models embedded by default, but it looks like I'm missing something else and a similar issue was opened by the testing bot [1] Afaik starting ffmpeg 5 models need to always be specified, I expect it to work better with embedded models but haven't tested it yet as I couldn't emerge it properly. I'll dig deeper into it, probably we'll go for the embed-models useflag [1] https://bugs.gentoo.org/837221
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=888a5176d519cbe68d1647f5af9c9180f17f2683 commit 888a5176d519cbe68d1647f5af9c9180f17f2683 Author: Adel KARA SLIMANE <adel.ks@zegrapher.com> AuthorDate: 2022-04-10 22:37:13 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-04-18 06:43:02 +0000 media-libs/libvmaf: fix tests and add embed-models useflag Closes: https://bugs.gentoo.org/837221 Closes: https://bugs.gentoo.org/837488 Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com> Closes: https://github.com/gentoo/gentoo/pull/24982 Signed-off-by: Joonas Niilola <juippis@gentoo.org> ...vmaf-2.3.0-r1.ebuild => libvmaf-2.3.0-r2.ebuild} | 21 +++++++++++++++++---- media-libs/libvmaf/metadata.xml | 3 +++ 2 files changed, 20 insertions(+), 4 deletions(-)
