Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836788 - media-libs/opencv doesn't allow USE="gtk3 opengl"
Summary: media-libs/opencv doesn't allow USE="gtk3 opengl"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-05 03:19 UTC by Matt Turner
Modified: 2022-05-19 03:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2022-04-05 03:19:33 UTC
In this commit:

commit 83780dade6becfbff566eb2e26a0ece5b1284063
Author: Ross Charles Campbell <rossbridger.cc@gmail.com>
Date:   Tue Sep 29 22:47:41 2020 +0800

    media-libs/opencv: version bump to 4.4.0

the new ebuild changed 

REQUIRED_USE="
    ...
    opengl? ( || ( gtk qt5 ) )
    ...
"

REQUIRED_USE="
    ...
    opengl? ( qt5 )
    ...
"

without any explanation. Allowing USE="gtk3 opengl" by reverting that change seems to work just fine.

Was this a mistake or was there a reason for the change?
Comment 1 Matt Turner gentoo-dev 2022-04-18 04:45:09 UTC
ping?
Comment 2 Larry the Git Cow gentoo-dev 2022-04-19 05:50:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4610dead81f9749649b0f5f0ddb8c412c9b4b7ea

commit 4610dead81f9749649b0f5f0ddb8c412c9b4b7ea
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-04-19 05:44:02 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-19 05:46:13 +0000

    media-libs/opencv: Allow USE="gtk3 opengl"
    
    Inexplicably removed in commit 83780dade6b ("media-libs/opencv: version
    bump to 4.4.0").
    
    Closes: https://bugs.gentoo.org/836788
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 media-libs/opencv/opencv-4.5.5-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 cyrillic 2022-04-20 00:35:28 UTC
I think the reason for this is in the CMakeLists.txt

When USE="-qt5" then opengl does not get considered. This is what I see from src_configure ()

-- 
--   GUI:                           GTK3
--     GTK+:                        YES (ver 3.24.33)
--       GThread :                  YES (ver 2.72.1)
--       GtkGlExt:                  NO
--     OpenGL support:              NO
--
Comment 4 Matt Turner gentoo-dev 2022-04-21 20:48:18 UTC
I think you're right. It looks like OpenGL support with GTK requires the gtk+2-era x11-libs/gtkglext package.

Unfortunate that the commit fails to note any of this, and even retains the following text:

> # OpenGL needs gtk or Qt installed to activate, otherwise build system
> # will silently disable it Wwithout the user knowing, which defeats the
> # purpose of the opengl use flag.
Comment 5 Larry the Git Cow gentoo-dev 2022-04-21 20:49:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e902c7ec3c0362ab4c240c20b5a4818dfb304b62

commit e902c7ec3c0362ab4c240c20b5a4818dfb304b62
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-04-21 20:48:32 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-21 20:48:55 +0000

    Revert "media-libs/opencv: Allow USE="gtk3 opengl""
    
    This reverts commit 4610dead81f9749649b0f5f0ddb8c412c9b4b7ea.
    
    Closes: https://bugs.gentoo.org/836788
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 media-libs/opencv/opencv-4.5.5-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)