Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836390 - mail-filter/postsrsd init script ignores parameters within confd
Summary: mail-filter/postsrsd init script ignores parameters within confd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dirkjan Ochtman (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-03-30 04:05 UTC by nic
Modified: 2022-04-07 14:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nic 2022-03-30 04:05:05 UTC
The following values in /etc/conf.d/postsrsd are not referenced in /etc/init.d/postsrsd

SRS_HASHLENGTH=4
SRS_HASHMIN=4
SRS_LISTEN_ADDR=127.0.0.1

Reproducible: Always

Actual Results:  
For instance, changing the hash length to non-default 4 value has no affect on the running program. ie 6

postsrsd -f 10001 -r 10002 -d example.com -s /etc/postsrsd.secret -a = -u nobody -p /var/run/postsrsd.pid -c /var/lib/postsrsd -D -X''





This addition within start() resolves the issue.

-n "$SRS_HASHLENGTH" -N "$SRS_HASHMIN" -l "$SRS_LISTEN_ADDR" \


postsrsd -f 10001 -r 10002 -d example.com -s /etc/postsrsd.secret -a = -u nobody -p /var/run/postsrsd.pid -c /var/lib/postsrsd -n 6 -N 6 -l 127.0.0.1 -D -X''

Thanks ;)
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2022-03-30 12:11:55 UTC
Hey, thanks for reporting. Would you be interested in submitting a patch for this change? A GitHub PR would be great, just a patch attachment here would work as well. You'll want to copy the current ebuild to an -r1 and make the changes there.
Comment 2 nic 2022-03-30 16:00:50 UTC
done. please advise if something doesn't look right :)
Comment 3 Larry the Git Cow gentoo-dev 2022-04-07 14:13:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=69853414eda033b50db1931eede45b520ab1de0d

commit 69853414eda033b50db1931eede45b520ab1de0d
Author:     nic <nic@boet.cc>
AuthorDate: 2022-03-30 15:55:50 +0000
Commit:     Dirkjan Ochtman <djc@gentoo.org>
CommitDate: 2022-04-07 14:12:41 +0000

    mail-filter/postsrsd fixes initd
    
    pass SRS_HASHLENGTH, SRS_HASHMIN, SRS_LISTEN_ADDR vars from confd into
    initd
    remove old unused init
    EAPI 8 the new ebuild
    
    Closes: https://bugs.gentoo.org/836390
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Nic Boet <nic@boet.cc>
    Signed-off-by: Dirkjan Ochtman <djc@gentoo.org>

 .../files/{postsrsd.init => postsrsd.init-r2}      |  7 +++--
 mail-filter/postsrsd/postsrsd-1.11-r1.ebuild       | 35 ++++++++++++++++++++++
 2 files changed, 39 insertions(+), 3 deletions(-)