Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836116 - sys-process/at: uses variables banned in scope (VariableScope)
Summary: sys-process/at: uses variables banned in scope (VariableScope)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: forbidden-variable-use
  Show dependency tree
 
Reported: 2022-03-26 03:42 UTC by Sam James
Modified: 2022-10-15 15:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-26 03:42:57 UTC
This package uses variables banned in some scopes. This may stop working in future versions of Portage.

$ pkgcheck scan -k VariableScope sys-process/at
sys-process/at
  VariableScope: version 3.2.2-r2: variable 'EROOT' used in 'src_install', line 78
  VariableScope: version 3.2.2-r4: variable 'EROOT' used in 'src_install', line 79
  VariableScope: version 3.2.4: variable 'EROOT' used in 'src_install', line 78
  VariableScope: version 3.2.5: variable 'EROOT' used in 'src_install', line 78
Comment 1 Anthony Basile gentoo-dev 2022-07-22 15:10:20 UTC
This is a confusing bug.  EROOT is used by prefix in many packages.  Do we drop it?  What's the fix here?
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-22 15:47:02 UTC
(In reply to Anthony Basile from comment #1)
> This is a confusing bug.  EROOT is used by prefix in many packages.  Do we
> drop it?  What's the fix here?

It completely depends on the use. EROOT is only valid in certain phases. A lot of the time, people want EPREFIX instead.

BROOT would work for calling build time tools and ESYSROOT is for finding deps.
Comment 3 Larry the Git Cow gentoo-dev 2022-10-15 15:34:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef0a41815008ef8e3f1e07d520e4ceb033a76d57

commit ef0a41815008ef8e3f1e07d520e4ceb033a76d57
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-15 15:33:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-15 15:33:35 +0000

    sys-process/at: fix VariableScope
    
    Closes: https://bugs.gentoo.org/836116
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-process/at/at-3.2.5.ebuild | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)