Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836040 - app-misc/splitvt: uses variables banned in scope (VariableScope)
Summary: app-misc/splitvt: uses variables banned in scope (VariableScope)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: forbidden-variable-use
  Show dependency tree
 
Reported: 2022-03-26 03:37 UTC by Sam James
Modified: 2022-12-21 10:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-26 03:37:04 UTC
This package uses variables banned in some scopes. This may stop working in future versions of Portage.

$ pkgcheck scan -k VariableScope app-misc/splitvt
app-misc/splitvt
  VariableScope: version 1.6.6-r3: variable 'D' used in 'src_prepare', lines 34, 35
Comment 1 Larry the Git Cow gentoo-dev 2022-11-22 07:05:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b821f8830d649f1f9fda4968551a676449d598e3

commit b821f8830d649f1f9fda4968551a676449d598e3
Author:     Pascal Jäger <pascal.jaeger@leimstift.de>
AuthorDate: 2022-11-02 14:30:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-22 06:57:39 +0000

    app-misc/splitvt: revbump, fix build with clang16, fix open bugs
    
    - Wrote a patch with modern C function definitions to make this work with clang16
    - sed in ebuild now uses | instead of : as delimiter
    - use ${ED} instead of ${D} now
    
    Closes: https://bugs.gentoo.org/871072
    Closes: https://bugs.gentoo.org/879639
    Closes: https://bugs.gentoo.org/710456
    Closes: https://bugs.gentoo.org/836040
    Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
    Closes: https://github.com/gentoo/gentoo/pull/28105
    Signed-off-by: Sam James <sam@gentoo.org>

 app-misc/splitvt/Manifest                |  1 +
 app-misc/splitvt/splitvt-1.6.6_p7.ebuild | 57 ++++++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)