Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835966 - x11-libs/gtk+-3.24.31 with x11-themes/adwaita-icon-theme-42.0: missing icons
Summary: x11-libs/gtk+-3.24.31 with x11-themes/adwaita-icon-theme-42.0: missing icons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://gitlab.gnome.org/GNOME/gtk/-/...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-03-24 23:06 UTC by Kobboi
Modified: 2022-04-05 23:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2022-03-24 23:06:11 UTC
geany-1.38 is missing most of its icons since the upgrade of adwaita-icon-theme from 41.0 to 42.0

$ geany

(geany:104982): Gtk-WARNING **: 00:02:42.185: Error loading theme icon 'document-new' for stock: Icon 'document-new' not present in theme Adwaita

(geany:104982): Gtk-WARNING **: 00:02:42.186: Error loading theme icon 'document-open' for stock: Icon 'document-open' not present in theme Adwaita

(geany:104982): Gtk-WARNING **: 00:02:42.186: Error loading theme icon 'document-save' for stock: Icon 'document-save' not present in theme Adwaita

(geany:104982): Gtk-WARNING **: 00:02:42.186: Error loading theme icon 'document-revert' for stock: 

(geany:104982): Gtk-WARNING **: 00:02:42.186: Error loading theme icon 'window-close' for stock: Icon 'window-close' not present in theme Adwaita

(geany:104982): Gtk-WARNING **: 00:02:42.186: Error loading theme icon 'go-previous' for stock: 

(geany:104982): Gtk-WARNING **: 00:02:42.186: Error loading theme icon 'go-next' for stock: 

(geany:104982): Gtk-WARNING **: 00:02:42.187: Error loading theme icon 'system-run' for stock: Icon 'system-run' not present in theme Adwaita

(geany:104982): Gtk-WARNING **: 00:02:42.187: Error loading theme icon 'edit-clear' for stock: 

(geany:104982): Gtk-WARNING **: 00:02:42.187: Error loading theme icon 'edit-find' for stock: Icon 'edit-find' not present in theme Adwaita

(geany:104982): Gtk-WARNING **: 00:02:42.187: Error loading theme icon 'edit-clear' for stock: 

(geany:104982): Gtk-WARNING **: 00:02:42.187: Error loading theme icon 'go-jump' for stock: 

(geany:104982): Gtk-WARNING **: 00:02:42.187: Error loading theme icon 'application-exit' for stock: Icon 'application-exit' not present in theme Adwaita

Seems to be the subject of https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/184 which mentions https://gitlab.gnome.org/GNOME/gtk/-/commit/5a0ffbbb4568e39bdf26006e1bf18c1c1d0d597a



Reproducible: Always
Comment 1 Matt Turner gentoo-dev 2022-03-27 04:34:15 UTC
I tried adding the patch to the v3.24.33 bump, but since it has binary changes in it eapply isn't able to handle it.
Comment 2 Kobboi 2022-03-27 11:35:17 UTC
Yeah, I logged that as https://bugs.gentoo.org/835964
Comment 3 daniel 2022-03-28 16:45:26 UTC
It seems, app-misc/solaar is affected too:

18:39:59,461  WARNING [MainThread] solaar.ui.icons: icon battery-good not found in current theme
Comment 4 Adrian Bassett 2022-03-28 16:52:16 UTC
(In reply to daniel from comment #3)
> It seems, app-misc/solaar is affected too:
> 
> 18:39:59,461  WARNING [MainThread] solaar.ui.icons: icon battery-good not
> found in current theme

As is media-sound/deadbeef - no start, stop, pause, etc. buttons.

Perhaps the title of this bug should be modified to enlarge its scope?
Comment 5 Andrey Grozin gentoo-dev 2022-03-30 07:20:10 UTC
It breaks dev-util/diffuse-0.7.3:

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.10/diffuse", line 33, in <module>
    sys.exit(main.main())
  File "/usr/share/diffuse/diffuse/main.py", line 1715, in main
    diff = Diffuse(rc_dir)
  File "/usr/share/diffuse/diffuse/main.py", line 661, in __init__
    p0 = default_theme.load_icon_for_scale("document-new", icon_size, scale_factor, 0)
gi.repository.GLib.GError: gtk-icon-theme-error-quark: Icon 'document-new' not present in theme gnome (0)
Comment 6 Larry the Git Cow gentoo-dev 2022-04-04 22:20:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=325aa03c15acdb93715c93789216fe5f59021cde

commit 325aa03c15acdb93715c93789216fe5f59021cde
Author:     Christophe Lermytte <gentoo@lermytte.be>
AuthorDate: 2022-04-04 21:31:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-04 22:19:55 +0000

    x11-libs/gtk+: add missing legacy icons
    
    Suggestion by sam to temporarily depend on git to apply this binary upstream patch,
    which should make it into the next upstream release.
    
    Closes: https://bugs.gentoo.org/835966
    Signed-off-by: Christophe Lermytte <gentoo@lermytte.be>
    Closes: https://github.com/gentoo/gentoo/pull/24909
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-libs/gtk+/Manifest               |   1 +
 x11-libs/gtk+/gtk+-3.24.33-r1.ebuild | 257 +++++++++++++++++++++++++++++++++++
 2 files changed, 258 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2022-04-05 23:48:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=94d629be892b5e22042f5130f485184964b975e5

commit 94d629be892b5e22042f5130f485184964b975e5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-05 23:48:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-05 23:48:37 +0000

    x11-libs/gtk+: fix bug reference in ebuild
    
    Bug: https://bugs.gentoo.org/835966
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-libs/gtk+/gtk+-3.24.33-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)