Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835838 - media-libs/xine-lib-1.2.12-r1: stabilisation
Summary: media-libs/xine-lib-1.2.12-r1: stabilisation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: CC-ARCHES
Depends on:
Blocks:
 
Reported: 2022-03-23 08:08 UTC by Sylvia
Modified: 2022-05-05 09:50 UTC (History)
3 users (show)

See Also:
Package list:
media-libs/xine-lib-1.2.12-r1
Runtime testing required: ---
nattka: sanity-check+


Attachments
xine-lib build log (xine-lib-build.log,280.31 KB, text/x-log)
2022-03-27 16:39 UTC, spock128
no flags Details
emerge --info (file_835838.txt,8.14 KB, text/plain)
2022-03-27 16:40 UTC, spock128
no flags Details
build.log (build.log,274.12 KB, text/x-log)
2022-04-03 07:59 UTC, nicotroost
no flags Details
emerge --info (emerge-info,6.80 KB, text/plain)
2022-04-03 08:00 UTC, nicotroost
no flags Details
support_dav1d_1.0.0.patch (support_dav1d_1.0.0.patch,1.23 KB, patch)
2022-04-15 22:28 UTC, Fitzcarraldo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvia 2022-03-23 08:08:02 UTC
dav1d.c: In function '_open_plugin':
dav1d.c:540:11: error: 'Dav1dSettings' has no member named 'n_frame_threads'
  540 |   settings.n_frame_threads = (ncpu > 8) ? 4 : (ncpu < 2) ? 1 : ncpu/2;
      |           ^
dav1d.c:541:12: error: 'Dav1dSettings' has no member named 'n_tile_threads'; did you mean 'n_threads'?
  541 |   settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1);
      |            ^~~~~~~~~~~~~~
      |            n_threads
In file included from ../../lib/os_internal.h:71,
                 from ../../include/config.h:47,
                 from dav1d.c:23:
dav1d.c:541:51: error: 'Dav1dSettings' has no member named 'n_frame_threads'
  541 |   settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1);
      |                                                   ^
dav1d.c:541:51: error: 'Dav1dSettings' has no member named 'n_frame_threads'
  541 |   settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1);
      |                                                   ^
In file included from ../../include/xine/input_plugin.h:28,
                 from ../../include/xine/xine_internal.h:35,
                 from dav1d.c:38:
dav1d.c:544:21: error: 'Dav1dSettings' has no member named 'n_frame_threads'
  544 |             settings.n_frame_threads, settings.n_tile_threads);
      |                     ^
../../include/xine/xineutils.h:676:40: note: in definition of macro 'xprintf'
  676 |         xine_log(xine, XINE_LOG_TRACE, __VA_ARGS__);                        \
      |                                        ^~~~~~~~~~~
dav1d.c:544:48: error: 'Dav1dSettings' has no member named 'n_tile_threads'; did you mean 'n_threads'?
  544 |             settings.n_frame_threads, settings.n_tile_threads);
      |                                                ^~~~~~~~~~~~~~
../../include/xine/xineutils.h:676:40: note: in definition of macro 'xprintf'
  676 |         xine_log(xine, XINE_LOG_TRACE, __VA_ARGS__);                        \
      |                                        ^~~~~~~~~~~
make[2]: *** [Makefile:1318: xineplug_decode_dav1d_la-dav1d.lo] Error 1


Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-23 13:37:31 UTC
This should be fixe already. Please emerge --sync and include the full build.log and emerge --info.
Comment 2 spock128 2022-03-27 16:39:31 UTC
Created attachment 768002 [details]
xine-lib build log
Comment 3 spock128 2022-03-27 16:40:53 UTC
Created attachment 768003 [details]
emerge --info
Comment 4 spock128 2022-03-27 16:43:49 UTC
Output of `emerge -pqv`

# FEATURES="-distcc" emerge -pqv '=media-libs/xine-lib-1.2.11::gentoo'
[ebuild   R   ] media-libs/xine-lib-1.2.11  USE="X a52 aac alsa css dts dvb flac gtk imagemagick ipv6 jpeg mad mmap mng musepack nls opengl pulseaudio samba sdl theora truetype v4l vdpau vorbis xv xvmc -aalib (-altivec) -bluray -dxr3 -fbcon -jack -libcaca -modplug -nfs -oss -sftp -speex -vaapi -vcd -vdr (-vidix) (-vis) -vpx -wavpack -wayland -xinerama"

fwiw
Comment 5 nicotroost 2022-04-03 07:59:35 UTC
Created attachment 768548 [details]
build.log

Same here.
build.log attached
Comment 6 nicotroost 2022-04-03 08:00:35 UTC
Created attachment 768549 [details]
emerge --info
Comment 7 nicotroost 2022-04-03 08:01:32 UTC
# emerge -pqv '=media-libs/xine-lib-1.2.11::gentoo'
[ebuild  N    ] media-libs/xine-lib-1.2.11  USE="X a52 aac alsa css dts flac gtk ipv6 jpeg mad mmap mng musepack opengl oss theora truetype v4l vdpau vorbis vpx xv xvmc -aalib (-altivec) -bluray -dvb -dxr3 -fbcon -imagemagick -jack -libcaca -modplug -nfs -nls -pulseaudio -samba -sdl -sftp -speex -vaapi -vcd -vdr (-vidix) (-vis) -wavpack -wayland -xinerama"
Comment 8 Fitzcarraldo 2022-04-15 22:28:10 UTC
Created attachment 770948 [details, diff]
support_dav1d_1.0.0.patch

I used the upstream patch attached to Debian Bug Report 1008607 as follows:

# mkdir -p /etc/portage/patches/media-libs/xine-lib-1.2.11
# cp /home/fitzcarraldo/Downloads/support_dav1d_1.0.0.patch /etc/portage/patches/media-libs/xine-lib-1.2.11/
# emerge -1v xine-lib

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] media-libs/xine-lib-1.2.11:1::gentoo  USE="X a52 aac alsa css dts dvb flac gtk ipv6 jpeg mad mmap mng musepack nls opengl pulseaudio sdl speex theora truetype v4l vorbis wayland xv -aalib (-altivec) -bluray -dxr3 -fbcon -imagemagick -jack -libcaca -modplug -nfs -oss -samba -sftp -vaapi -vcd -vdpau -vdr (-vidix) (-vis) -vpx -wavpack -xinerama -xvmc" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB

>>> Verifying ebuild manifests
>>> Emerging (1 of 1) media-libs/xine-lib-1.2.11::gentoo
>>> Installing (1 of 1) media-libs/xine-lib-1.2.11::gentoo
>>> Jobs: 1 of 1 complete                           Load avg: 1.76, 1.75, 1.14
>>> Auto-cleaning packages...

>>> No outdated packages were found on your system.

 * GNU info directory index is up-to-date.
# eix -I xine-lib
[I] media-libs/xine-lib
     Available versions:  (1) 1.2.10 1.2.11 ~1.2.12-r1 **1.2.9999*l
       {+X a52 aac aalib +alsa altivec bluray +css dav1d dts dvb dxr3 fbcon flac gtk imagemagick ipv6 jack jpeg libcaca mad +mmap mng modplug musepack nfs nls opengl oss pulseaudio samba sdl sftp speex theora truetype v4l vaapi vcd vdpau vdr vidix +vis vorbis vpx wavpack wayland xinerama +xv xvmc}
     Installed versions:  1.2.11(1)(23:16:29 15/04/22)(X a52 aac alsa css dts dvb flac gtk ipv6 jpeg mad mmap mng musepack nls opengl pulseaudio sdl speex theora truetype v4l vorbis wayland xv -aalib -altivec -bluray -dxr3 -fbcon -imagemagick -jack -libcaca -modplug -nfs -oss -samba -sftp -vaapi -vcd -vdpau -vdr -vidix -vis -vpx -wavpack -xinerama -xvmc)
     Homepage:            http://xine.sourceforge.net/
     Description:         Core libraries for Xine movie player

# eix -I dav1d
[I] media-libs/dav1d
     Available versions:  0.9.2(0/5)^t (~)1.0.0(0/6)^t **9999(0/6)*l^t {+8bit +10bit +asm test xxhash ABI_MIPS="n32 n64 o32" ABI_S390="32 64" ABI_X86="32 64 x32"}
     Installed versions:  1.0.0(0/6)^t(18:41:36 15/04/22)(8bit 10bit asm -test -xxhash ABI_MIPS="-n32 -n64 -o32" ABI_S390="-32 -64" ABI_X86="32 64 -x32")
     Homepage:            https://code.videolan.org/videolan/dav1d
     Description:         dav1d is an AV1 Decoder :)

#
Comment 9 Frank Noack 2022-04-30 14:30:55 UTC
(In reply to Fitzcarraldo from comment #8)

> I used the upstream patch attached to Debian Bug Report 1008607 as follows:
> 
> # mkdir -p /etc/portage/patches/media-libs/xine-lib-1.2.11
> # cp /home/fitzcarraldo/Downloads/support_dav1d_1.0.0.patch
> /etc/portage/patches/media-libs/xine-lib-1.2.11/
> # emerge -1v xine-lib

This patch solved my problem. Thanks
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-02 02:11:28 UTC
(In reply to Sam James from comment #1)
> This should be fixe already. Please emerge --sync and include the full
> build.log and emerge --info.

commit 377be0b52f115818ea3c2d00367f0b2b5c91b0f1
Author: Sam James <sam@gentoo.org>
Date:   Tue Mar 22 16:53:01 2022 +0000

    media-libs/xine-lib: fix automagic libaom, dav1d; fix build with dav1d-1.0.0

    Closes: https://bugs.gentoo.org/835791
    Signed-off-by: Sam James <sam@gentoo.org>

I already fixed this with the exact same patch. The issue is you're using ~arch dav1d on stable and stable xine-lib isn't fixed yet.

But oh well, it's time to stable anyway.
Comment 11 NATTkA bot gentoo-dev 2022-05-02 02:16:21 UTC Comment hidden (obsolete)
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-02 19:03:20 UTC
amd64 done
Comment 13 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-05-03 17:48:04 UTC
arm64 done
Comment 14 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-05-03 17:48:42 UTC
ppc done
Comment 15 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-05-03 17:48:44 UTC
ppc64 done
Comment 16 Agostino Sarubbo gentoo-dev 2022-05-05 09:50:11 UTC
x86 stable. Closing.