Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835830 - games-util/lutris should recommend installing media-libs/vulkan-loader via optfeature
Summary: games-util/lutris should recommend installing media-libs/vulkan-loader via op...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Nowa Ammerlaan
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-23 07:07 UTC by Bodo Thiesen
Modified: 2022-04-12 09:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bodo Thiesen 2022-03-23 07:07:30 UTC
games-util/lutris could use a vulkan use flag defaulting enabled to pull in media-libs/vulkan-loader
Comment 1 Emily Rowlands 2022-03-23 11:24:14 UTC
it looks like an optional runtime dependency that doesn't require a rebuild, so should probably be an optfeature rather than a USE flag
Comment 2 Matt Turner gentoo-dev 2022-03-24 00:17:55 UTC
(In reply to Emily Rowlands from comment #1)
> it looks like an optional runtime dependency that doesn't require a rebuild,
> so should probably be an optfeature rather than a USE flag

++

In addition, pulling in the Vulkan loader isn't sufficient to run Vulkan applications. You'd have to have something like a virtual/vulkan that was satisfied by a hardware driver, but we've moved away from things like that because it's really not necessary and it's not really tractable. E.g. in virtual/opencl we just have it pull in one of the two opencl loaders.

tl;dr: please don't add vulkan USE flags that just pull in a runtime dependency.
Comment 3 Larry the Git Cow gentoo-dev 2022-04-12 09:08:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e18d138658d27755382ad3c2ef1ff7a0338be788

commit e18d138658d27755382ad3c2ef1ff7a0338be788
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-04-12 08:51:54 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-04-12 09:08:31 +0000

    games-util/lutris: add 0.5.10
    
    - update LICENSE
    
    Bug: https://bugs.gentoo.org/706432
    
    - add vulkan-loader optfeature
    
    Closes: https://bugs.gentoo.org/835830
    
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 games-util/lutris/Manifest             |  1 +
 games-util/lutris/lutris-0.5.10.ebuild | 87 ++++++++++++++++++++++++++++++++++
 2 files changed, 88 insertions(+)