Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835763 - dev-python/pyside2-5.15.5, dev-python/pyside2-tools-5.15.5 and dev-python/shiboken2-5.15.5 version bump
Summary: dev-python/pyside2-5.15.5, dev-python/pyside2-tools-5.15.5 and dev-python/shi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: https://download.qt.io/official_relea...
Whiteboard:
Keywords: PullRequest
: 858686 (view as bug list)
Depends on:
Blocks: 840434
  Show dependency tree
 
Reported: 2022-03-21 19:33 UTC by Andreas Sturmlechner
Modified: 2022-08-15 20:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2022-03-21 19:33:50 UTC
Released on March 3rd.

https://lists.qt-project.org/pipermail/development/2022-March/042262.html
Comment 1 Andreas Sturmlechner gentoo-dev 2022-06-01 21:02:03 UTC
Released on May 11th:

https://lists.qt-project.org/pipermail/development/2022-May/042437.html
Comment 2 Andreas Sturmlechner gentoo-dev 2022-06-14 07:25:20 UTC
ping.
Comment 3 Andreas Sturmlechner gentoo-dev 2022-06-18 21:09:25 UTC
Released today:

https://lists.qt-project.org/pipermail/development/2022-June/042659.html
Comment 4 Andreas Sturmlechner gentoo-dev 2022-07-17 12:11:22 UTC
Adding previous committers to this bug, since it is clear metadata.xml maintainer is uninterested. There are several open issues.

It seems that Gentoo added py3-10 support to pyside-5.15.2 with only a smallish patch, but there are several commits upstream, see link.

Andrew, please don't scrub git commit summary from patches so we are clear where they are coming from.

www-client/falkon is impossible to build against pyside2 currently (tested with py39, py310, py311). I am considering just dropping python support in that package, considering it is badly maintained anyway.
Comment 5 Andrew Ammerlaan gentoo-dev 2022-07-17 13:23:27 UTC
(In reply to Andreas Sturmlechner from comment #4)
> Adding previous committers to this bug, since it is clear metadata.xml
> maintainer is uninterested. There are several open issues.

I tried bumping this earlier, but I ran into a bunch of build failures and gave up at some point. I'll try the new version later and see if I have more luck with that one.
 
> Andrew, please don't scrub git commit summary from patches so we are clear
> where they are coming from.

I am getting conflicting advice on this. If I leave it in someone comes and complains to me that I should remove it (waste of space). If I remove it someone complains that I should have kept it (loss of information). Is there any QA consensus or policy that definitively tells me which way is the "correct" way? FWIW, I agree with you that it is usefull to keep this information. However at some point I started removing it because folks kept telling me to.
Comment 6 Andreas Sturmlechner gentoo-dev 2022-07-17 13:28:57 UTC
(In reply to Andrew Ammerlaan from comment #5)
> (In reply to Andreas Sturmlechner from comment #4)
> > Andrew, please don't scrub git commit summary from patches so we are clear
> > where they are coming from.
> 
> I am getting conflicting advice on this. If I leave it in someone comes and
> complains to me that I should remove it (waste of space).
That's wild, who does that? At the very least keep commit id, author, title.

Anyway, at the very minimum, if git summary is *excessively* big, linking to the upstream repository commit instead is a must.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-17 13:32:26 UTC
A good rule of thumb is using iwdevtools' scrub-patch which drops the useless parts (git noise, 'diff --git ....', etc) but _not_ the summary and commit message.

https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html#clean-patch-howto

I also then always include a link to where I found the commit.
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-17 13:32:53 UTC
(keeps hash too)
Comment 9 Andreas Sturmlechner gentoo-dev 2022-07-17 13:43:25 UTC
(In reply to Andreas Sturmlechner from comment #4)
> www-client/falkon is impossible to build against pyside2 currently (tested
> with py39, py310, py311). I am considering just dropping python support in
> that package, considering it is badly maintained anyway.
At least regarding the downstream patches they do not seem to be responsible for the falkon build failure as 3.2.0 still manages to build fine against current pyside2/shiboken2.
Comment 10 Andreas Sturmlechner gentoo-dev 2022-07-18 11:38:51 UTC
*** Bug 858686 has been marked as a duplicate of this bug. ***
Comment 11 Larry the Git Cow gentoo-dev 2022-08-12 10:53:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=597060fbfc992bbc3dd46f4cf189a35780a61f98

commit 597060fbfc992bbc3dd46f4cf189a35780a61f98
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2022-07-24 09:18:29 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-08-12 10:53:03 +0000

    dev-python/pyside2: add 5.15.5
    
    Closes: https://bugs.gentoo.org/835763
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 dev-python/pyside2/Manifest              |   1 +
 dev-python/pyside2/pyside2-5.15.5.ebuild | 224 +++++++++++++++++++++++++++++++
 2 files changed, 225 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fcec8a16e07ae0adb240e42b70491e63f554000

commit 3fcec8a16e07ae0adb240e42b70491e63f554000
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2022-07-20 15:21:45 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-08-12 10:53:02 +0000

    dev-python/shiboken2: add 5.15.5
    
    Bug: https://bugs.gentoo.org/835763
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 dev-python/shiboken2/Manifest                      |   1 +
 ...oken2-5.15.5-add-numpy-1.23-compatibility.patch |  31 ++++
 .../files/shiboken2-5.15.5-python311-1.patch       |  72 +++++++++
 .../files/shiboken2-5.15.5-python311-2.patch       |  65 ++++++++
 .../files/shiboken2-5.15.5-python311-3.patch       |  55 +++++++
 dev-python/shiboken2/shiboken2-5.15.5.ebuild       | 172 +++++++++++++++++++++
 6 files changed, 396 insertions(+)