Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835702 - sci-libs/gmsh-4.9.5-r1 does not properly honor USE=opencascade
Summary: sci-libs/gmsh-4.9.5-r1 does not properly honor USE=opencascade
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthias Maier
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2022-03-21 00:19 UTC by kevinmbecause
Modified: 2022-06-13 12:41 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild which works with USE=opencascade (gmsh-4.9.5-r2.ebuild,2.44 KB, text/plain)
2022-03-21 00:19 UTC, kevinmbecause
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kevinmbecause 2022-03-21 00:19:25 UTC
Created attachment 767481 [details]
Updated ebuild which works with USE=opencascade

The cmake script does not find the libraries installed by current sci-libs/opencascade. The build completes, but does not include support for opencascade. This is shown in the build options summary at the end of the configure step.

Expected:
--  * Build options: 64Bit ALGLIB[contrib] ANN[contrib] Bamg Blossom Cairo DIntegration Dlopen DomHex Eigen[contrib] Fltk GMP Gmm[contrib] Hxt Jpeg Kbipack LinuxJoystick MathEx[contrib] Mesh Metis[contrib] Mpeg ONELAB ONELABMetamodel OpenCASCADE OpenCASCADE-CAF OpenGL OpenMP OptHom Parser Plugins Png Post QuadMeshingTools QuadTri Solver TetGen/BR Voro++[contrib] WinslowUntangler Zlib

Actual Result:
--  * Build options: 64Bit ALGLIB[contrib] ANN[contrib] Bamg Blossom Cairo DIntegration Dlopen DomHex Eigen[contrib] Fltk GMP Gmm[contrib] Hxt Jpeg Kbipack LinuxJoystick MathEx[contrib] Mesh Metis[contrib] Mpeg ONELAB ONELABMetamodel OpenGL OpenMP OptHom Parser Plugins Png Post QuadMeshingTools QuadTri Solver TetGen/BR Voro++[contrib] WinslowUntangler Zlib

I have created an ebuild which passes the locations of all of the opencascade libraries to cmake and it produces working builds.
Comment 1 Jonas Stein gentoo-dev 2022-03-21 22:29:17 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck scan --net
* Please remove obsolete lines like PATCHES=()
* Please introduce local variables with "local"
* A bot can look for additional mistakes, if you upload a PR via github
Comment 2 Larry the Git Cow gentoo-dev 2022-06-06 05:49:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7124c42f8e7ff9926f8474f49cc0c9a3870391d7

commit 7124c42f8e7ff9926f8474f49cc0c9a3870391d7
Author:     Fabio Rossi <rossi.f@inwind.it>
AuthorDate: 2022-05-24 11:57:04 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2022-06-06 05:49:21 +0000

    sci-libs/gmsh: various improvements
    
    * removed deprecated dep
    * fixed installation with USE=examples
    * fixed detection of opencascade
    * now the private API is also exported with USE=shared
    
    Signed-off-by: Fabio Rossi <rossi.f@inwind.it>
    Bug: https://bugs.gentoo.org/835702
    Bug: https://bugs.gentoo.org/835194
    Signed-off-by: Matthias Maier <tamiko@gentoo.org>

 sci-libs/gmsh/files/gmsh-4.9.5-opencascade.patch | 20 ++++++
 sci-libs/gmsh/gmsh-4.9.5-r2.ebuild               | 80 ++++++++++++++++++++++++
 2 files changed, 100 insertions(+)