Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835419 - media-video/ffmpeg: backport patch to fix ranlib GNU hardcoding
Summary: media-video/ffmpeg: backport patch to fix ranlib GNU hardcoding
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-16 11:26 UTC by Adrian Ratiu
Modified: 2022-03-16 15:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Ratiu 2022-03-16 11:26:55 UTC
Hi. ffmpeg ignores the --ranlib="$(tc-getRANLIB) option we set in the ebuilds due to an upstream bug which I've fixed.

I would like to backport the fix so I created:

https://github.com/gentoo/gentoo/pull/24602



Reproducible: Always

Steps to Reproduce:
1. Ensure the --ranlib="$(tc-getRANLIB) points to llvm-ranlib
2. Build and observe that GNU ranlib is used

Actual Results:  
GNU ranlib is used instead of the properly configured llvm ranlib

Expected Results:  
There is an upstream fix we can backport, I've created a github PR:

https://github.com/gentoo/gentoo/pull/24602
Comment 1 Larry the Git Cow gentoo-dev 2022-03-16 15:18:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad0cb7464d90af3480697b3695b84751f9890f77

commit ad0cb7464d90af3480697b3695b84751f9890f77
Author:     Adrian Ratiu <adrian.ratiu@collabora.com>
AuthorDate: 2022-03-16 11:20:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-03-16 15:17:28 +0000

    media-video/ffmpeg: backport small GNU ranlib hardcoding fix
    
    I've landed this fix in ffmpeg upstream and would like to backport
    it to Gentoo so the --ranlib="$(tc-getRANLIB) option set in the
    ebuilds has an effect, to be able to use the LLVM tool which is
    currently ignored.
    
    Because this is a small fix not impacting the majority of users
    who don't care about mixed LLVM/GNU tools usage, I don't think
    we nede to bump the ebuild revisons to cause rebuilds.
    
    Closes: https://bugs.gentoo.org/835419
    Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
    Closes: https://github.com/gentoo/gentoo/pull/24602
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/ffmpeg/ffmpeg-4.2.4-r1.ebuild          |  2 +-
 media-video/ffmpeg/ffmpeg-4.3.1-r1.ebuild          |  1 +
 media-video/ffmpeg/ffmpeg-4.3.2-r1.ebuild          |  1 +
 media-video/ffmpeg/ffmpeg-4.4-r1.ebuild            |  1 +
 media-video/ffmpeg/ffmpeg-4.4.1-r2.ebuild          |  1 +
 media-video/ffmpeg/ffmpeg-5.0.ebuild               |  1 +
 .../ffmpeg-5.0-backport-ranlib-build-fix.patch     | 59 ++++++++++++++++++++++
 7 files changed, 65 insertions(+), 1 deletion(-)