.
Given https://gitweb.gentoo.org/repo/gentoo.git/commit/dev-libs/rocksdb?id=9a5672672cbda260a4fb713a266f50f4724f23df, is this supposed to still be -riscv...?
Unable to check for sanity: > package masked: dev-libs/rocksdb-6.17.3, by keywords: -riscv
I just tested dev-libs/rocksdb(specifically version 6.17.3) on rv64 platform and it still caused a failed build... The error: /var/tmp/portage/dev-libs/rocksdb-6.17.3/work/rocksdb-6.17.3/utilities/transactions/lock/range/range_tree/lib/locktree/../portability/toku_time.h:137:2: error: #error No timer implementation for this platform A PR to resolve it has been created on the upstream repository(ref: https://github.com/facebook/rocksdb/pull/9215 ) but has yet to be merged into the latest version.
(In reply to Yun Pan from comment #3) > > A PR to resolve it has been created on the upstream repository(ref: > https://github.com/facebook/rocksdb/pull/9215 ) but has yet to be merged > into the latest version. the patch looks good, as it won't affect other arches, so pretty much safe to apply, also it seems also been tested by llvm project. so @dinoallo, could you send us a PR? if all tested and went well @chutzpah mind you take a look? and give and ACK if we want to proceed..
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9a5aa114a86f922264d686b4ca900ae277288c3 commit e9a5aa114a86f922264d686b4ca900ae277288c3 Author: Yun Pan <dinoallo@netc.it> AuthorDate: 2022-03-14 14:58:03 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2022-03-19 04:10:00 +0000 dev-libs/rocksdb: re-keyword riscv for rocksdb 6.17.3 Closes: https://bugs.gentoo.org/834855 Closes: https://github.com/gentoo/gentoo/pull/24557 Signed-off-by: Yun Pan <dinoallo@netc.it> Signed-off-by: Yixun Lan <dlan@gentoo.org> dev-libs/rocksdb/rocksdb-6.17.3.ebuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=678c1515b3327a7876ef8e3e118db4ab9e5d8e63 commit 678c1515b3327a7876ef8e3e118db4ab9e5d8e63 Author: Yun Pan <dinoallo@netc.it> AuthorDate: 2022-03-15 14:48:49 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2022-03-19 04:09:24 +0000 dev-libs/rocksdb: fix check for libatomic The original patch that comes with rocksdb 6.14.6 is inadequate to check if libatomic is required on some architectures. The new patch superseded the old one in version 6.17.3. Along with patch e8fc99f, rocksdb 6.17.3 can now be compiled on riscv. Bug: https://bugs.gentoo.org/834855 Signed-off-by: Yun Pan <dinoallo@netc.it> Signed-off-by: Yixun Lan <dlan@gentoo.org> .../rocksdb/files/rocksdb-6.17.3-libatomic.patch | 71 ++++++++++++++++++++++ dev-libs/rocksdb/rocksdb-6.17.3.ebuild | 2 +- 2 files changed, 72 insertions(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b005163fb832df44f7c0cabeb7b54b7d7ea61080 commit b005163fb832df44f7c0cabeb7b54b7d7ea61080 Author: Yun Pan <dinoallo@netc.it> AuthorDate: 2022-03-15 14:45:12 +0000 Commit: Yixun Lan <dlan@gentoo.org> CommitDate: 2022-03-19 04:09:20 +0000 dev-libs/rocksdb: add timer for riscv platform See: https://bugs.gentoo.org/834855#c3 Related upstream PR: https://github.com/facebook/rocksdb/pull/9215 Bug: https://bugs.gentoo.org/834855 Signed-off-by: Yun Pan <dinoallo@netc.it> Signed-off-by: Yixun Lan <dlan@gentoo.org> .../files/rocksdb-6.17.3-add_timer_for_riscv.patch | 40 ++++++++++++++++++++++ dev-libs/rocksdb/rocksdb-6.17.3.ebuild | 1 + 2 files changed, 41 insertions(+)
