Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 834846 - dev-libs/nss: emerge failed on chromiumos chroot environment. Needs to export LD to achieve cross-board build
Summary: dev-libs/nss: emerge failed on chromiumos chroot environment. Needs to export...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2022-03-09 17:46 UTC by Zi Lin
Modified: 2022-03-30 13:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Use $LD instead of ld in Linux.mk (nss-3.68.2-nss-ld-fixup.patch,1.14 KB, application/mbox)
2022-03-11 20:26 UTC, Zi Lin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zi Lin 2022-03-09 17:46:59 UTC
currently emerge will fail at our ChromeOS builds because of a direct ld invocation that likely to break across different boards.

Direct ld usage:

nss/coreconf/Linux.mk#L160

Will require a NSS upstream fix to use $(LD) instead.
Comment 1 Joonas Niilola gentoo-dev 2022-03-10 16:59:20 UTC
Hey, 

thanks. I'll contact upstream. Do you want us to patch it meanwhile for our versions, or just try to get it done via upstream and it'll be ready when they are ready?
Comment 2 Zi Lin 2022-03-11 20:26:50 UTC
Created attachment 766803 [details]
Use $LD instead of ld in Linux.mk
Comment 3 Zi Lin 2022-03-11 20:30:27 UTC
If you can submit patch to the upstream please go ahead. I created this bug initially thinking that my upstream patch would also require some updates in the ebuild file (namely export $LD with $(tc-getLD)). But my testing said otherwise. So it appears that just patch the upstream nss will work just fine for me now.

I am pretty new to the NSS patch submit flow so by the time I get the Mercury setup, someone may already fix it.

Reference nss bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1758741
Comment 4 Larry the Git Cow gentoo-dev 2022-03-29 07:20:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d74294e90fea6298740a2833fcbfa285647b25b6

commit d74294e90fea6298740a2833fcbfa285647b25b6
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-03-29 06:55:20 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-03-29 07:20:39 +0000

    dev-libs/nss: add 3.76.1
    
     - respect LD.
    
    Bug: https://bugs.gentoo.org/834846
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/nss/Manifest                    |   1 +
 dev-libs/nss/files/nss-3.68-ld-fix.patch |  29 +++
 dev-libs/nss/nss-3.76.1.ebuild           | 363 +++++++++++++++++++++++++++++++
 3 files changed, 393 insertions(+)
Comment 5 Zi Lin 2022-03-29 20:21:04 UTC
Thank you very much, I think this is fixed.
Comment 6 Joonas Niilola gentoo-dev 2022-03-30 13:51:40 UTC
All thanks to you Lin! But it's still missing from the NSS-ESR, i.e. 3.68. Will get it to the next release, either from upstream or by manually patching temporarily.