Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 834725 - sys-apps/dbus-1.12.22 fails test - FAIL: test-bus-launch-helper.sh 1 ../bus/test-bus-launch-helper (exit status 134)
Summary: sys-apps/dbus-1.12.22 fails test - FAIL: test-bus-launch-helper.sh 1 ../bus/t...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 836242
  Show dependency tree
 
Reported: 2022-03-07 16:23 UTC by Toralf Förster
Modified: 2022-03-31 19:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.88 KB, text/plain)
2022-03-07 16:23 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,16.13 KB, text/plain)
2022-03-07 16:23 UTC, Toralf Förster
Details
environment (environment,170.43 KB, text/plain)
2022-03-07 16:23 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,9.78 KB, application/x-bzip)
2022-03-07 16:23 UTC, Toralf Förster
Details
sys-apps:dbus-1.12.22:20220307-155539.log.bz2 (sys-apps:dbus-1.12.22:20220307-155539.log.bz2,24.11 KB, application/x-bzip)
2022-03-07 16:23 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,99.34 KB, application/x-bzip)
2022-03-07 16:23 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2022-03-07 16:23:23 UTC
	< /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22/test/tap-test.sh.in > test-bus.sh
PASS: test-bus.sh 1 ../bus/test-bus
sed -e 's![@]RUN[@]!../bus/test-bus-launch-helper!' \
	< /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22/test/tap-test.sh.in > test-bus-launch-helper.sh
FAIL: test-bus-launch-helper.sh 1 ../bus/test-bus-launch-helper (exit status 134)
sed -e 's![@]RUN[@]!../bus/test-bus-system!' \
	< /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22/test/tap-test.sh.in > test-bus-system.sh

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_systemd-j4_test-20220307-094637

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11.2.1 *
clang/llvm (if any):
/usr/lib/llvm/13
13.0.1
Python 3.9.9
Available Rust versions:
  [1]   rust-bin-1.59.0 *
php cli:

  HEAD of ::gentoo
commit 67d34cd84f23f9b50e69b42919dbc66cb0de928c
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Mon Mar 7 15:07:02 2022 +0000

    2022-03-07 15:06:59 UTC

emerge -qpvO sys-apps/dbus
[ebuild     U ] sys-apps/dbus-1.12.22 [1.12.20-r4] USE="X debug* systemd test* -doc (-elogind) (-selinux) -static-libs" ABI_X86="(64) -32 (-x32)"
Comment 1 Toralf Förster gentoo-dev 2022-03-07 16:23:25 UTC
Created attachment 766477 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2022-03-07 16:23:26 UTC
Created attachment 766478 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2022-03-07 16:23:27 UTC
Created attachment 766479 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2022-03-07 16:23:28 UTC
Created attachment 766480 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2022-03-07 16:23:29 UTC
Created attachment 766481 [details]
sys-apps:dbus-1.12.22:20220307-155539.log.bz2
Comment 6 Toralf Förster gentoo-dev 2022-03-07 16:23:31 UTC
Created attachment 766482 [details]
temp.tar.bz2
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-27 02:44:14 UTC
Is the test/test-suite.log file somewhere in an attachment I am missing?
Comment 8 Toralf Förster gentoo-dev 2022-03-27 09:38:40 UTC
(In reply to Sam James from comment #7)
> Is the test/test-suite.log file somewhere in an attachment I am missing?

It is rather b.g.o. which avoids to attach those monsters:

# tar -tvf logs.tar.bz2
-rw-r--r-- portage/portage 244309 2022-03-07 16:55 ./dbus-1.12.22-abi_x86_64.amd64/config.log
-rw-r--r-- portage/portage 245264 2022-03-07 16:56 ./dbus-1.12.22-tests-build/config.log
-rw-r--r-- portage/portage   4814 2022-03-07 16:56 ./dbus-1.12.22-tests-build/test/test-bus-launch-helper.log
-rw-r--r-- portage/portage  95313 2022-03-07 16:56 ./dbus-1.12.22-tests-build/test/test-bus-system.log
-rw-r--r-- portage/portage 600666365 2022-03-07 16:56 ./dbus-1.12.22-tests-build/test/test-bus.log
-rw-r--r-- portage/portage    336007 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-corrupt.log
-rw-r--r-- portage/portage   2242818 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-dbus-daemon-eavesdrop.log
-rw-r--r-- portage/portage    329560 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-dbus-daemon-fork.log
-rw-r--r-- portage/portage 619472371 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-dbus-daemon.log
-rw-r--r-- portage/portage    141583 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-dbus-launch-eval.log
-rw-r--r-- portage/portage      2334 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-dbus-launch-x11.log
-rw-r--r-- portage/portage 2279236155 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-dbus.log
-rw-r--r-- portage/portage    3310950 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-fdpass.log
-rw-r--r-- portage/portage     475736 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-loopback.log
-rw-r--r-- portage/portage       4943 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-marshal.log
-rw-r--r-- portage/portage     328155 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-message.log
-rw-r--r-- portage/portage    9567722 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-monitor.log
-rw-r--r-- portage/portage        180 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-printf.log
-rw-r--r-- portage/portage 1318716410 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-refs.log
-rw-r--r-- portage/portage  291879820 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-relay.log
-rw-r--r-- portage/portage    2708653 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-sd-activation.log
-rw-r--r-- portage/portage    2175619 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-server-oom.log
-rw-r--r-- portage/portage       1934 2022-03-07 16:57 ./dbus-1.12.22-tests-build/test/test-shell.log
-rw-r--r-- portage/portage  619480949 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-suite.log
-rw-r--r-- portage/portage        569 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-syntax.log
-rw-r--r-- portage/portage        158 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-syslog.log
-rw-r--r-- portage/portage        985 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-uid-permissions.log
-rw-r--r-- portage/portage     661647 2022-03-07 16:59 ./dbus-1.12.22-tests-build/test/test-variant.log

You can download that 200 MB file logs.tar.bz2 from the same URI where needed.txt is lcoated
Comment 9 Toralf Förster gentoo-dev 2022-03-27 10:10:52 UTC
The file size of files/logs.tar.bz2 is too big (223M) for un upload. For about 8 weeks the link http://tinderbox.zwiebeltoralf.de:31560/17.1_desktop_systemd-j4_test-20220307-094637/var/tmp/tb/issues/20220307-165918-sys-apps_dbus-1.12.22/files/logs.tar.bz2 is valid.
Comment 10 Mike Gilbert gentoo-dev 2022-03-27 18:50:54 UTC
I looks like something tries to open /proc/self/oom_score_adj and fails with EBADF (Bad file descriptor).

FAIL: test-bus-launch-helper
============================

452: 0x7fcd065fbc00: 1646668608.059575 [dbus/dbus-internals.c(1047):_dbus_test_oom_handling] Running once to count mallocs
452: 0x7fcd065fbc00: 1646668608.059598 [bus/activation-helper.c(443):get_correct_parser] dbus-daemon-activation-helper: using config file: /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/test/data/valid-config-files-system/debug-allow-all-pass.conf
452: 0x7fcd065fbc00: 1646668608.059674 [dbus/dbus-file-unix.c(80):_dbus_file_get_contents] file fd 4 opened
452: 0x7fcd065fbc00: 1646668608.059709 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'busconfig' type '1'
452: 0x7fcd065fbc00: 1646668608.059722 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'listen' type '4'
452: 0x7fcd065fbc00: 1646668608.059729 [bus/config-parser-trivial.c(335):bus_config_parser_content]  CONTENTS We don't care about 'debug-pipe:name=test-server' type '4'
452: 0x7fcd065fbc00: 1646668608.059735 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'listen' type '4'
452: 0x7fcd065fbc00: 1646668608.059740 [bus/config-parser-trivial.c(335):bus_config_parser_content]  CONTENTS We don't care about 'unix:tmpdir=/var/tmp/portage/sys-apps/dbus-1.12.22/temp' type '4'
452: 0x7fcd065fbc00: 1646668608.059770 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'policy' type '6'
452: 0x7fcd065fbc00: 1646668608.059777 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'allow' type '8'
452: 0x7fcd065fbc00: 1646668608.059784 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'allow' type '8'
452: 0x7fcd065fbc00: 1646668608.059790 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'allow' type '8'
452: 0x7fcd065fbc00: 1646668608.059795 [bus/config-parser-trivial.c(212):bus_config_parser_start_element]  START We don't care about 'allow' type '8'
452: 0x7fcd065fbc00: 1646668608.059802 [bus/config-parser-trivial.c(354):bus_config_parser_finished] finished scanning!
452: 0x7fcd065fbc00: 1646668608.059811 [bus/activation-helper.c(91):desktop_file_for_name] Looking at '/var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/test/data/valid-service-files-system'
452: 0x7fcd065fbc00: 1646668608.059819 [bus/activation-helper.c(106):desktop_file_for_name] Trying to load file '/var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/test/data/valid-service-files-system/org.freedesktop.DBus.TestSuiteEchoService.service'
452: 0x7fcd065fbc00: 1646668608.059863 [dbus/dbus-file-unix.c(80):_dbus_file_get_contents] file fd 4 opened
452: 0x7fcd065fbc00: 1646668608.059895 [bus/activation-helper.c(482):launch_bus_name] dbus-daemon-activation-helper: Name='org.freedesktop.DBus.TestSuiteEchoService'
452: 0x7fcd065fbc00: 1646668608.059900 [bus/activation-helper.c(483):launch_bus_name] dbus-daemon-activation-helper: Exec='/var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/test/test-service'
452: 0x7fcd065fbc00: 1646668608.059904 [bus/activation-helper.c(484):launch_bus_name] dbus-daemon-activation-helper: User='anyrandomuser'
dbus[452]: open(/proc/self/oom_score_adj): Bad file descriptor
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/dbus/.libs/libdbus-1.so.3(_dbus_print_backtrace+0x32) [0x7fcd06cae642]
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/dbus/.libs/libdbus-1.so.3(_dbus_abort+0x9) [0x7fcd06cb2269]
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/dbus/.libs/libdbus-1.so.3(_dbus_warn_check_failed+0) [0x7fcd06c98f60]
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/bus/.libs/test-bus-launch-helper(run_launch_helper+0x732) [0x5623691f32b2]
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/bus/.libs/test-bus-launch-helper(+0x5ed0) [0x5623691efed0]
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/dbus/.libs/libdbus-1.so.3(_dbus_test_oom_handling+0x5f) [0x7fcd06c99eef]
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/bus/.libs/test-bus-launch-helper(main+0x11a) [0x5623691efcfa]
  /lib64/libc.so.6(+0x2934a) [0x7fcd0695734a]
  /lib64/libc.so.6(__libc_start_main+0x7c) [0x7fcd069573fc]
  /var/tmp/portage/sys-apps/dbus-1.12.22/work/dbus-1.12.22-tests-build/bus/.libs/test-bus-launch-helper(_start+0x21) [0x5623691efda1]
./test-bus-launch-helper.sh: line 20:   452 Aborted                 ../bus/test-bus-launch-helper 1>&2
1..1
not ok 1 ../bus/test-bus-launch-helper (exit status 134)
FAIL: test-bus-launch-helper.sh 1 ../bus/test-bus-launch-helper (exit status 134)
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-27 18:54:18 UTC
Oh, I hit that when trying to look at 1.14 too
Comment 12 Mike Gilbert gentoo-dev 2022-03-27 19:01:58 UTC
I suspect this is a regression introduced in this commit: https://github.com/freedesktop/dbus/commit/f3ffe9a873708c679df88b9fc12b6b831539cf8a

On 1636 of dbus/dbus-sysdeps-util-unix.c, the code calls _dbus_fd_set_close_on_exec on a file descriptor which may not be valid if the open() call above it fails.
Comment 13 Mike Gilbert gentoo-dev 2022-03-27 19:02:51 UTC
Actually, it might not be a "regression", but I suspect that bit of code is still to blame.
Comment 14 Mike Gilbert gentoo-dev 2022-03-27 19:18:00 UTC
Sent a patch upstream.
Comment 15 Toralf Förster gentoo-dev 2022-03-31 15:40:25 UTC
I checked at an arbitrary image for those files:

17-1-desktop-plasma-systemd-j4-20220206-100006 /var/tmp/tb # tail -v /proc/self/oom_*
==> /proc/self/oom_adj <==
0

==> /proc/self/oom_score <==
666

==> /proc/self/oom_score_adj <==
0
Comment 16 Larry the Git Cow gentoo-dev 2022-03-31 16:25:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=327024d4f4606f13c70655d4b67d8b03c447b23f

commit 327024d4f4606f13c70655d4b67d8b03c447b23f
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-03-31 16:23:53 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-03-31 16:24:38 +0000

    sys-apps/dbus: backport fix for _dbus_reset_oom_score_adj
    
    Closes: https://bugs.gentoo.org/834725
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-apps/dbus/dbus-1.12.22.ebuild               |  6 +++--
 sys-apps/dbus/dbus-1.14.0.ebuild                |  7 +++---
 sys-apps/dbus/files/dbus-1.12.22-check-fd.patch | 33 +++++++++++++++++++++++++
 3 files changed, 41 insertions(+), 5 deletions(-)