Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 834671 - dev-util/flatpak-builder-1.0.11 - ./.../glnx-dirfd.h: error: implicit declaration of function TEMP_FAILURE_RETRY [-Werror=implicit
Summary: dev-util/flatpak-builder-1.0.11 - ./.../glnx-dirfd.h: error: implicit declara...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo musl team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-03-06 14:09 UTC by Toralf Förster
Modified: 2022-04-11 19:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.38 KB, text/plain)
2022-03-06 14:09 UTC, Toralf Förster
Details
dev-util:flatpak-builder-1.0.11:20220306-140509.log (dev-util:flatpak-builder-1.0.11:20220306-140509.log,19.01 KB, text/plain)
2022-03-06 14:09 UTC, Toralf Förster
Details
emerge-history.txt.bz2 (emerge-history.txt.bz2,54.78 KB, application/x-bzip)
2022-03-06 14:09 UTC, Toralf Förster
Details
environment (environment,22.58 KB, text/plain)
2022-03-06 14:09 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,19.55 KB, application/x-bzip)
2022-03-06 14:09 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,12.19 KB, application/x-bzip)
2022-03-06 14:09 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,11.01 KB, application/x-bzip)
2022-03-06 14:09 UTC, Toralf Förster
Details
flatpak-builder patch, fixes libglnx by defining the glibc macro unless it's already defined (file_834671.txt,642 bytes, patch)
2022-04-06 06:34 UTC, Alfred Persson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2022-03-06 14:09:30 UTC
too long lines were shrinked:

x86_64-gentoo-linux-musl-gcc -DHAVE_CONFIG_H -I.  -DFLATPAK_BINDIR=\"/usr/bin\" -DFLATPAK_BASEDIR=\"/usr/share/flatpak-builder\" -DG_LOG_DOMAIN=\"flatpak-builder\" -I./libglnx -include "config.h"   -pipe -Wall -Werror=empty-body -Werror=strict-prototypes -Werror=missing-prototypes -Werror=implicit-f
In file included from ./libglnx/libglnx.h:34,
                 from src/builder-main.c:30:
./libglnx/glnx-dirfd.h: In function 'glnx_ensure_dir':
./libglnx/glnx-dirfd.h:108:7: error: implicit declaration of function 'TEMP_FAILURE_RETRY' [-Werror=implicit-function-declaration]
  108 |   if (TEMP_FAILURE_RETRY (mkdirat (dfd, path, mode)) != 0)
      |       ^~~~~~~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0_musl_hardened-j4-20220304-030006

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-gentoo-linux-musl-11.2.1 *
clang/llvm (if any):
clang version 13.0.1
Target: x86_64-gentoo-linux-musl
Thread model: posix
InstalledDir: /usr/lib/llvm/13/bin
/usr/lib/llvm/13
13.0.1
Python 3.9.10
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby27 (with Rubygems)
  [3]   ruby30 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.59.0
  [2]   rust-1.59.0 *
The following VMs are available for generation-2:
*)	Eclipse Temurin JDK 11.0.14_p9 [openjdk-bin-11]
Available Java Virtual Machines:
  [1]   openjdk-bin-11  system-vm

php cli:

  HEAD of ::gentoo
commit 0b563b9574b95d2c18bc6e1498821a14aac1856d
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Sun Mar 6 13:22:03 2022 +0000

    2022-03-06 13:22:01 UTC

emerge -qpvO dev-util/flatpak-builder
[ebuild  N    ] dev-util/flatpak-builder-1.0.11  USE="yaml -doc"
Comment 1 Toralf Förster gentoo-dev 2022-03-06 14:09:31 UTC
Created attachment 766421 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2022-03-06 14:09:38 UTC
Created attachment 766422 [details]
dev-util:flatpak-builder-1.0.11:20220306-140509.log
Comment 3 Toralf Förster gentoo-dev 2022-03-06 14:09:40 UTC
Created attachment 766423 [details]
emerge-history.txt.bz2
Comment 4 Toralf Förster gentoo-dev 2022-03-06 14:09:41 UTC
Created attachment 766424 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2022-03-06 14:09:42 UTC
Created attachment 766425 [details]
etc.portage.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2022-03-06 14:09:43 UTC
Created attachment 766426 [details]
logs.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2022-03-06 14:09:44 UTC
Created attachment 766427 [details]
temp.tar.bz2
Comment 8 Alfred Persson 2022-04-06 06:34:51 UTC
Created attachment 768936 [details, diff]
flatpak-builder patch, fixes libglnx by defining the glibc macro unless it's already defined
Comment 9 Larry the Git Cow gentoo-dev 2022-04-07 01:54:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0c051ae8fa760db1ed92bc9bdcaf30d7a53481e

commit f0c051ae8fa760db1ed92bc9bdcaf30d7a53481e
Author:     Alfred Persson <cat@catcream.org>
AuthorDate: 2022-04-07 01:46:53 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2022-04-07 01:52:19 +0000

    dev-util/flatpak-builder: add musl patch
    
    Closes: https://bugs.gentoo.org/834671
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 .../files/flatpak-builder-1.2.2-musl.patch             | 18 ++++++++++++++++++
 dev-util/flatpak-builder/flatpak-builder-1.2.2.ebuild  |  2 ++
 2 files changed, 20 insertions(+)
Comment 10 Zac Medico gentoo-dev 2022-04-07 01:55:11 UTC
Thanks!
Comment 11 Alfred Persson 2022-04-11 15:06:08 UTC
(In reply to Zac Medico from comment #10)
> Thanks!

No problem! The patch was for version 1.0.11, 1.2.2 needed additional patching in debugedit. I made a pull request fixing both on Github
Comment 12 Yury German Gentoo Infrastructure gentoo-dev 2022-04-11 17:39:17 UTC
Reopening as per request. To add appropriate patches for both versions.
Comment 13 Larry the Git Cow gentoo-dev 2022-04-11 19:19:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43e759c25a8e2960d3dff78c6696cb257ebaa394

commit 43e759c25a8e2960d3dff78c6696cb257ebaa394
Author:     Alfred Persson Forsberg <cat@catcream.org>
AuthorDate: 2022-04-11 13:49:23 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2022-04-11 19:18:58 +0000

    dev-util/flatpak-builder: fixed building for musl
    
    Closes: https://github.com/gentoo/gentoo/pull/24991
    Closes: https://bugs.gentoo.org/834671
    Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 .../files/flatpak-builder-1.0.11-musl.patch        | 18 +++++++
 .../files/flatpak-builder-1.2.2-musl.patch         | 55 +++++++++++++++++++++-
 .../flatpak-builder/flatpak-builder-1.0.11.ebuild  |  2 +
 3 files changed, 73 insertions(+), 2 deletions(-)
Comment 14 Zac Medico gentoo-dev 2022-04-11 19:19:40 UTC
Thanks again!