Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 834582 - x11-misc/xscreensaver-6.03 fails configure when USE=-opengl
Summary: x11-misc/xscreensaver-6.03 fails configure when USE=-opengl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
: 834728 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-03-04 18:17 UTC by Hank Leininger
Modified: 2022-03-12 00:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hank Leininger 2022-03-04 18:17:32 UTC
Between xscreensaver 6.02 and 6.03, "configure" changed to make disabling opengl a fatal error:

/var/tmp/portage/x11-misc $ diff -u xscreensaver-6.02-r1/work/xscreensaver-6.02/configure xscreensaver-6.03/work/xscreensaver-6.03/configure | less
...
@@ -20903,10 +22948,13 @@
 if test "$have_gl" = no ; then
   if test "$with_gl_req" = yes ; then
     warnL 'Use of GL was requested, but it was not found.'
+    CONF_STATUS=1
   elif test "$with_gl_req" = no ; then
     noteL 'The OpenGL 3D library is not being used.'
+    CONF_STATUS=1
   else
     noteL 'The OpenGL 3D library was not found.'
+    CONF_STATUS=1
   fi
 
   if test "$gl_halfassed" = yes ; then
...
@@ -21031,3 +23083,5 @@
 echo "             App Defaults:  ${APPDEFAULTS}/$addir_err"
 echo ""
 
+exit $CONF_STATUS
+


Note, CONF_STATUS=1 is set even when opengl was not requested. Then at the end of configure, the exit $CONF_STATUS was added.

The result is configure output that looks exactly like it did in 6.02 and before (a note that opengl is not being used), but then exit 1 so that portage aborts.

I've reported this upstream, will submit a PR shortly.
Comment 1 Francis Norberg 2022-03-07 18:29:55 UTC
*** Bug 834728 has been marked as a duplicate of this bug. ***
Comment 2 Larry the Git Cow gentoo-dev 2022-03-12 00:10:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6566d4988d100cbbfb4fec194576e69bc53d7386

commit 6566d4988d100cbbfb4fec194576e69bc53d7386
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2022-03-04 18:34:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-03-12 00:09:50 +0000

    x11-misc/xscreensaver: fix configure with USE=-opengl
    
    Deliberately disabling opengl became a fatal error in configure.
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/834582
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Closes: https://github.com/gentoo/gentoo/pull/24404
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/xscreensaver-6.03-without-gl-configure.patch        | 11 +++++++++++
 x11-misc/xscreensaver/xscreensaver-6.03.ebuild                |  1 +
 2 files changed, 12 insertions(+)