Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833893 - media-sound/picard-2.7.3: missing requirements
Summary: media-sound/picard-2.7.3: missing requirements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-22 14:58 UTC by Kobboi
Modified: 2022-07-08 11:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2022-02-22 14:58:27 UTC
(Running as root, since that user does not have manually installed packages):

$ sudo pip check
picard 2.7.3 requires discid, which is not installed.
picard 2.7.3 requires pyjwt, which is not installed.

Runtime: W: 15:57:21,955 /usr/lib/python3.9/site-packages/picard/ui/mainwindow.create_actions:652: CDROM: discid library not found - Lookup CD functionality disabled



Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2022-07-08 04:03:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=63ee7b89d10c72f4f87c92512ed633203d8fec7a

commit 63ee7b89d10c72f4f87c92512ed633203d8fec7a
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2022-07-08 04:02:57 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2022-07-08 04:02:57 +0000

    media-sound/picard: bump to 2.8.2, added missing deps
    
    Closes: https://bugs.gentoo.org/833893
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/picard/Manifest            |  1 +
 media-sound/picard/picard-2.8.1.ebuild |  2 ++
 media-sound/picard/picard-2.8.2.ebuild | 65 ++++++++++++++++++++++++++++++++++
 media-sound/picard/picard-2.8.ebuild   |  2 ++
 media-sound/picard/picard-9999.ebuild  |  4 ++-
 5 files changed, 73 insertions(+), 1 deletion(-)
Comment 2 Tomasz Golinski 2022-07-08 10:34:59 UTC
discid dependence was already controlled by USE-flag. Why it was added unconditionally? Lack of this package was not breaking Picard, it was disabling some runtime feature that not everybody needed.

If this dependence is to be unconditional, why not remove the USE flag completely?
Comment 3 Miroslav Šulc gentoo-dev 2022-07-08 11:08:30 UTC
(In reply to Tomasz Golinski from comment #2)
> discid dependence was already controlled by USE-flag. Why it was added
> unconditionally? Lack of this package was not breaking Picard, it was
> disabling some runtime feature that not everybody needed.
> 
> If this dependence is to be unconditional, why not remove the USE flag
> completely?

my bad, will fix that, thanks
Comment 4 Larry the Git Cow gentoo-dev 2022-07-08 11:09:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2525f101d658ec39926bfcbf1e76dd8fe2450200

commit 2525f101d658ec39926bfcbf1e76dd8fe2450200
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2022-07-08 11:08:59 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2022-07-08 11:09:17 +0000

    media-sound/picard: fixed discid dep
    
    Bug: https://bugs.gentoo.org/833893
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/picard/picard-2.8.1.ebuild | 1 -
 media-sound/picard/picard-2.8.2.ebuild | 1 -
 media-sound/picard/picard-9999.ebuild  | 1 -
 3 files changed, 3 deletions(-)